From fb3d3fba791b5b200293d23f08b778ecae34e02f Mon Sep 17 00:00:00 2001 From: Armando Montanez Date: Tue, 9 Jun 2020 18:12:12 -0700 Subject: Don't declare pigweed variables as globals Require targets to explicitly import pigweed variable definitions. This moves out some necessary logic from the BUILDCONFIG.gn file. Change-Id: If9c9fe5a680cc9d897a0e8a55889873be618ed84 --- pw_string/BUILD.gn | 5 ++++- pw_string/size_report/BUILD.gn | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) (limited to 'pw_string') diff --git a/pw_string/BUILD.gn b/pw_string/BUILD.gn index 6bf9cce11..0e1165fe9 100644 --- a/pw_string/BUILD.gn +++ b/pw_string/BUILD.gn @@ -12,11 +12,14 @@ # License for the specific language governing permissions and limitations under # the License. +# gn-format disable +import("//build_overrides/pigweed.gni") + +import("$dir_pigweed/legacy_target.gni") import("$dir_pw_bloat/bloat.gni") import("$dir_pw_build/target_types.gni") import("$dir_pw_docgen/docs.gni") import("$dir_pw_unit_test/test.gni") - config("default_config") { include_dirs = [ "public" ] } diff --git a/pw_string/size_report/BUILD.gn b/pw_string/size_report/BUILD.gn index 9a6374425..7fcce7ad1 100644 --- a/pw_string/size_report/BUILD.gn +++ b/pw_string/size_report/BUILD.gn @@ -12,8 +12,11 @@ # License for the specific language governing permissions and limitations under # the License. -import("$dir_pw_build/target_types.gni") +# gn-format disable +import("//build_overrides/pigweed.gni") +import("$dir_pigweed/legacy_target.gni") +import("$dir_pw_build/target_types.gni") pw_executable("single_write_snprintf") { sources = [ "format_single.cc" ] deps = [ -- cgit v1.2.3