summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2022-05-19 11:23:25 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2022-05-19 11:23:25 +0000
commit41bdf52d58334073e4a23543d641ed716d9f3eae (patch)
tree9c7beb6d035ed599e94604752bf84298dd640b37
parent08f15a5982d05f977e79869c9216b9f7cd32eebf (diff)
parentf1682f0e43c660152fe525b23497d0942ffdf91a (diff)
downloadppp-41bdf52d58334073e4a23543d641ed716d9f3eae.tar.gz
Merge "pppd: add error string for setuid" am: f1682f0e43
Original change: https://android-review.googlesource.com/c/platform/external/ppp/+/2098554 Change-Id: I5b3ef68280d961dcde07ebd40b2e0e2eb319e797 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--pppd/main.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/pppd/main.c b/pppd/main.c
index 09f5a53..df4e36c 100644
--- a/pppd/main.c
+++ b/pppd/main.c
@@ -1735,10 +1735,9 @@ device_script(program, in, out, dont_wait)
/* here we are executing in the child */
setgid(getgid());
- setuid(uid);
- if (getuid() != uid) {
- fprintf(stderr, "pppd: setuid failed\n");
- exit(1);
+ if (setuid(uid) < 0) {
+ fprintf(stderr, "pppd: setuid failed: %s\n", strerror(errno));
+ exit(1);
}
update_system_environment();
#if defined(__ANDROID__)