diff options
| author | Paul Yang <TeBoring@users.noreply.github.com> | 2019-02-25 15:13:59 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-02-25 15:13:59 -0800 |
| commit | 5d8cd3b89577eef7b229157d4330b66fbb2f3f46 (patch) | |
| tree | e562c9dcf14c1fc4ecfb6933990836725c33968c | |
| parent | 580e1890a640677ecc4ca4161a32f42e35db4281 (diff) | |
| download | protobuf-5d8cd3b89577eef7b229157d4330b66fbb2f3f46.tar.gz | |
Date and time need to be before version (#5777)
| -rw-r--r-- | php/ext/google/protobuf/package.xml | 4 | ||||
| -rwxr-xr-x | update_version.py | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/php/ext/google/protobuf/package.xml b/php/ext/google/protobuf/package.xml index 76e02904c..877678c40 100644 --- a/php/ext/google/protobuf/package.xml +++ b/php/ext/google/protobuf/package.xml @@ -10,6 +10,8 @@ <email>protobuf-opensource@google.com</email> <active>yes</active> </lead> + <date>2019-02-22</date> + <time>11:31:21</time> <version> <release>3.7.0RC3</release> <api>3.7.0</api> @@ -18,8 +20,6 @@ <release>beta</release> <api>beta</api> </stability> - <date>2019-02-22</date> - <time>11:31:21</time> <license uri="https://opensource.org/licenses/BSD-3-Clause">3-Clause BSD License</license> <notes>GA release.</notes> <contents> diff --git a/update_version.py b/update_version.py index 42e632dfb..dcc25317f 100755 --- a/update_version.py +++ b/update_version.py @@ -213,6 +213,9 @@ def UpdatePhp(): return elem root = document.documentElement + now = datetime.datetime.now() + ReplaceText(Find(root, 'date'), now.strftime('%Y-%m-%d')) + ReplaceText(Find(root, 'time'), now.strftime('%H:%M:%S')) version = Find(root, 'version') ReplaceText(Find(version, 'release'), GetFullVersion(rc_suffix = 'RC')) ReplaceText(Find(version, 'api'), NEW_VERSION) @@ -220,9 +223,6 @@ def UpdatePhp(): ReplaceText(Find(stability, 'release'), 'stable' if RC_VERSION == 0 else 'beta') ReplaceText(Find(stability, 'api'), 'stable' if RC_VERSION == 0 else 'beta') - now = datetime.datetime.now() - ReplaceText(Find(root, 'date'), now.strftime('%Y-%m-%d')) - ReplaceText(Find(root, 'time'), now.strftime('%H:%M:%S')) changelog = Find(root, 'changelog') for old_version in changelog.getElementsByTagName('version'): if Find(old_version, 'release').firstChild.nodeValue == NEW_VERSION: |