aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYilei Yang <yileiyang@google.com>2017-09-22 12:11:40 -0700
committerYilei Yang <yileiyang@google.com>2017-09-25 10:31:47 -0700
commit99d72774ba05271cf2aa6d9cf80da8508ae48d59 (patch)
tree4045d2739be52c04d29734fd24227548101567cc
parent9b5d766f40f8ff1d2c74c88b95340fdc01a42ef2 (diff)
downloadabsl-py-99d72774ba05271cf2aa6d9cf80da8508ae48d59.tar.gz
Clean up unused code.
PiperOrigin-RevId: 169720771
-rw-r--r--absl/app.py1
-rw-r--r--absl/flags/_flagvalues.py6
-rw-r--r--absl/flags/_helpers.py2
-rw-r--r--absl/logging/__init__.py2
-rw-r--r--absl/logging/tests/verbosity_flag_test.py2
-rw-r--r--setup.py2
6 files changed, 1 insertions, 14 deletions
diff --git a/absl/app.py b/absl/app.py
index d3e6823..5d65162 100644
--- a/absl/app.py
+++ b/absl/app.py
@@ -209,7 +209,6 @@ def _run_main(main, argv):
elif FLAGS.run_with_profiling or FLAGS.profile_file:
# Avoid import overhead since most apps (including performance-sensitive
# ones) won't be run with profiling.
-
import atexit
if FLAGS.use_cprofile_for_profiling:
import cProfile as profile
diff --git a/absl/flags/_flagvalues.py b/absl/flags/_flagvalues.py
index ede0e5d..fb621c9 100644
--- a/absl/flags/_flagvalues.py
+++ b/absl/flags/_flagvalues.py
@@ -683,7 +683,6 @@ class FlagValues(object):
flag_dict = self._flags()
args = iter(args)
- non_gnu_break = False # Whether args scanning breaks because of non-gnu.
for arg in args:
value = None
@@ -700,7 +699,6 @@ class FlagValues(object):
if self.is_gnu_getopt():
continue
else:
- non_gnu_break = True
break
if arg == '--':
@@ -723,7 +721,6 @@ class FlagValues(object):
if self.is_gnu_getopt():
continue
else:
- non_gnu_break = True
break
# --undefok is a special case.
@@ -773,8 +770,7 @@ class FlagValues(object):
else:
unknown_flags.append((name, arg))
- remaining_args = list(args)
- unparsed_args.extend(remaining_args)
+ unparsed_args.extend(list(args))
return unknown_flags, unparsed_args, undefok
def is_parsed(self):
diff --git a/absl/flags/_helpers.py b/absl/flags/_helpers.py
index 8eb8f56..7bd5fac 100644
--- a/absl/flags/_helpers.py
+++ b/absl/flags/_helpers.py
@@ -24,7 +24,6 @@ import re
import struct
import sys
import textwrap
-
try:
import fcntl
except ImportError:
@@ -38,7 +37,6 @@ except ImportError:
import six
-
_DEFAULT_HELP_WIDTH = 80 # Default width of help output.
_MIN_HELP_WIDTH = 40 # Minimal "sane" width of help output. We assume that any
# value below 40 is unreasonable.
diff --git a/absl/logging/__init__.py b/absl/logging/__init__.py
index 282bd27..551cf43 100644
--- a/absl/logging/__init__.py
+++ b/absl/logging/__init__.py
@@ -84,14 +84,12 @@ from absl import flags
from absl.logging import converter
import six
-
if six.PY2:
import thread as _thread_lib # For .get_ident().
else:
import threading as _thread_lib # For .get_ident().
-
FLAGS = flags.FLAGS
diff --git a/absl/logging/tests/verbosity_flag_test.py b/absl/logging/tests/verbosity_flag_test.py
index 66436d2..4609e64 100644
--- a/absl/logging/tests/verbosity_flag_test.py
+++ b/absl/logging/tests/verbosity_flag_test.py
@@ -31,12 +31,10 @@ assert logging.root.getEffectiveLevel() == logging.ERROR, (
'logging.root level should be changed to ERROR, but found {}'.format(
logging.root.getEffectiveLevel()))
-
from absl import flags
from absl import logging as _ # pylint: disable=unused-import
from absl.testing import absltest
-
FLAGS = flags.FLAGS
assert FLAGS['verbosity'].value == -1, (
diff --git a/setup.py b/setup.py
index cfd5200..54d7007 100644
--- a/setup.py
+++ b/setup.py
@@ -20,7 +20,6 @@ from __future__ import print_function
import platform
-
try:
import setuptools
except ImportError:
@@ -28,7 +27,6 @@ except ImportError:
use_setuptools()
import setuptools
-
py_version = platform.python_version_tuple()
if py_version < ('2', '7') or py_version[0] == '3' and py_version < ('3', '4'):
raise RuntimeError('Python version 2.7 or 3.4+ is required.')