diff options
| author | Richard Levasseur <rlevasseur@google.com> | 2019-07-16 14:15:58 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2019-07-16 14:16:17 -0700 |
| commit | f7bd709c2040a5c4d366ec101c7b817358dbed8e (patch) | |
| tree | 6817b2805a81b7514ef3843afa55b7d9b4b6db7d /absl/flags/tests | |
| parent | ffc424196a58fd568edbf555290e3a80e781d5d7 (diff) | |
| download | absl-py-f7bd709c2040a5c4d366ec101c7b817358dbed8e.tar.gz | |
Make non-None flag tests assert warnings after capturing is finished.
Performing asserts on the warnings while they are being captured can
fail if the asserts (or their helper code) triggers a warning.
Fixes #108
PiperOrigin-RevId: 258438168
Change-Id: Ica91eb527445c25e258471a9e5003aaf3a713ab0
Diffstat (limited to 'absl/flags/tests')
| -rw-r--r-- | absl/flags/tests/_validators_test.py | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/absl/flags/tests/_validators_test.py b/absl/flags/tests/_validators_test.py index 4252a0a..a5dec45 100644 --- a/absl/flags/tests/_validators_test.py +++ b/absl/flags/tests/_validators_test.py @@ -504,13 +504,13 @@ class MarkFlagsAsMutualExclusiveTest(absltest.TestCase): expected, self.flag_values, argv) def test_flag_default_not_none_warning(self): - with warnings.catch_warnings(record=True) as w: + with warnings.catch_warnings(record=True) as caught_warnings: warnings.simplefilter('always') self._mark_flags_as_mutually_exclusive(['flag_one', 'flag_not_none'], False) - self.assertLen(w, 1) - self.assertIn('--flag_not_none has a non-None default value', - str(w[0].message)) + self.assertLen(caught_warnings, 1) + self.assertIn('--flag_not_none has a non-None default value', + str(caught_warnings[0].message)) class MarkBoolFlagsAsMutualExclusiveTest(absltest.TestCase): @@ -619,13 +619,14 @@ class MarkFlagAsRequiredTest(absltest.TestCase): def test_flag_default_not_none_warning(self): _defines.DEFINE_string( 'flag_not_none', '', 'empty default', flag_values=self.flag_values) - with warnings.catch_warnings(record=True) as w: + with warnings.catch_warnings(record=True) as caught_warnings: warnings.simplefilter('always') _validators.mark_flag_as_required( 'flag_not_none', flag_values=self.flag_values) - self.assertLen(w, 1) - self.assertIn('--flag_not_none has a non-None default value', - str(w[0].message)) + + self.assertLen(caught_warnings, 1) + self.assertIn('--flag_not_none has a non-None default value', + str(caught_warnings[0].message)) class MarkFlagsAsRequiredTest(absltest.TestCase): |