diff options
| author | Karol M. Langner <langner@google.com> | 2020-09-30 10:16:10 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2020-09-30 10:16:31 -0700 |
| commit | 9a0552c6743d387df6ab565f8ccb9878dd14ece4 (patch) | |
| tree | c76a5e4fab205b0d04f3073c2836e8d0dcc93bec /absl/testing/flagsaver.py | |
| parent | dab1732ed9cfe85f97e940a24a4c3a5d52a530f7 (diff) | |
| download | absl-py-9a0552c6743d387df6ab565f8ccb9878dd14ece4.tar.gz | |
In flagsaver, set multiple flags together before their validators run.
This resolves an issue where multi-flag validators rely on specific flag combinations.
PiperOrigin-RevId: 334625442
Change-Id: I7e6b625637a70356df57a4d9cbb01c203f14df4c
Diffstat (limited to 'absl/testing/flagsaver.py')
| -rwxr-xr-x | absl/testing/flagsaver.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/absl/testing/flagsaver.py b/absl/testing/flagsaver.py index 9a0e193..c33d56a 100755 --- a/absl/testing/flagsaver.py +++ b/absl/testing/flagsaver.py @@ -62,7 +62,6 @@ import functools import inspect from absl import flags -import six FLAGS = flags.FLAGS @@ -156,8 +155,7 @@ class _FlagOverrider(object): def __enter__(self): self._saved_flag_values = save_flag_values(FLAGS) try: - for name, value in six.iteritems(self._overrides): - setattr(FLAGS, name, value) + FLAGS._set_attributes(**self._overrides) except: # It may fail because of flag validators. restore_flag_values(self._saved_flag_values, FLAGS) |