From b2f076836dca9079acc32a9971846bc300944f33 Mon Sep 17 00:00:00 2001 From: Yilei Yang Date: Thu, 20 Feb 2020 10:32:55 -0800 Subject: Remove the FlagHolder.non_none_value method for now, we might use a different approach. Also the type annotations in _flagvalues.py should have _T instead of T. PiperOrigin-RevId: 296243519 Change-Id: I01cc7b8ef733ac78b671252a9afe8e7038c25d1b --- absl/flags/tests/_flagvalues_test.py | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'absl/flags/tests') diff --git a/absl/flags/tests/_flagvalues_test.py b/absl/flags/tests/_flagvalues_test.py index 978b8a5..db11608 100644 --- a/absl/flags/tests/_flagvalues_test.py +++ b/absl/flags/tests/_flagvalues_test.py @@ -862,16 +862,6 @@ class FlagHolderTest(absltest.TestCase): self.parse_flags('--name=new_value') self.assertEqual('new_value', self.name_flag.value) - def test_non_none_value_fails_if_value_is_none(self): - self.parse_flags() - self.fv.name = None - with self.assertRaises(_exceptions.NoneValueError): - _ = self.name_flag.non_none_value - - def test_non_none_value(self): - self.parse_flags('--name=default') - self.assertEqual('default', self.name_flag.non_none_value) - def test_allow_override(self): first = _defines.DEFINE_integer( 'int_flag', 1, 'help', flag_values=self.fv, allow_override=1) -- cgit v1.2.3