From 454aa79fcec321e0a7203136fd5a0d0a3bce02ae Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Tue, 12 Nov 2019 12:27:34 -0800 Subject: Update absl.testing's --test_randomize_ordering_seed flag default value from None to empty string. This doesn't change the behavior when the flag is using its default value. PiperOrigin-RevId: 280027756 Change-Id: I69261156b67bf20d31f5133cbb2d06287b8deb58 --- absl/testing/absltest.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'absl/testing/absltest.py') diff --git a/absl/testing/absltest.py b/absl/testing/absltest.py index c65a034..39acba1 100644 --- a/absl/testing/absltest.py +++ b/absl/testing/absltest.py @@ -207,11 +207,8 @@ def _get_default_randomize_ordering_seed(): ValueError: Raised when the flag or env value is not one of the options above. """ - if FLAGS.test_randomize_ordering_seed is not None: - randomize = FLAGS.test_randomize_ordering_seed - else: - randomize = os.environ.get('TEST_RANDOMIZE_ORDERING_SEED') - if randomize is None: + randomize = FLAGS.test_randomize_ordering_seed + if not randomize: return 0 if randomize == 'random': return random.Random().randint(1, 4294967295) @@ -239,12 +236,14 @@ flags.DEFINE_string('test_srcdir', flags.DEFINE_string('test_tmpdir', get_default_test_tmpdir(), 'Directory for temporary testing files', allow_override_cpp=True) -flags.DEFINE_string('test_randomize_ordering_seed', None, +flags.DEFINE_string('test_randomize_ordering_seed', + os.environ.get('TEST_RANDOMIZE_ORDERING_SEED', ''), 'If positive, use this as a seed to randomize the ' 'execution order for test cases. If "random", pick a ' 'random seed to use. If 0 or not set, do not randomize ' 'test case execution order. This flag also overrides ' - 'the TEST_RANDOMIZE_ORDERING_SEED environment variable.') + 'the TEST_RANDOMIZE_ORDERING_SEED environment variable.', + allow_override_cpp=True) flags.DEFINE_string('xml_output_file', '', 'File to store XML test results') -- cgit v1.2.3