Use basestring when checking for dictionary patching.

Fixes https://github.com/testing-cabal/mock/issues/458.

2 files changed, 9 insertions, 1 deletions

diff --git a/mock/mock.py b/mock/mock.py
index 7f3bafe..5d4b420 100644
--- a/mock/mock.py
+++ b/mock/mock.py
@@ -1768,7 +1768,7 @@ class _patch_dict(object):
 
     def _patch_dict(self):
         values = self.values
-        if isinstance(self.in_dict, str):
+        if isinstance(self.in_dict, basestring):
             self.in_dict = _importer(self.in_dict)
         in_dict = self.in_dict
         clear = self.clear
diff --git a/mock/tests/testpatch.py b/mock/tests/testpatch.py
index 958ea7f..bbd6d26 100644
--- a/mock/tests/testpatch.py
+++ b/mock/tests/testpatch.py
@@ -656,6 +656,14 @@ class PatchTest(unittest.TestCase):
         test()
 
 
+    def test_patch_dict_with_unicode(self):
+        @patch.dict(u'os.environ', {'konrad_delong': 'some value'})
+        def test():
+            self.assertIn('konrad_delong', os.environ)
+
+        test()
+
+
     def test_patch_dict_decorator_resolution(self):
         # bpo-35512: Ensure that patch with a string target resolves to
         # the new dictionary during function call