deprecate direct node construction and introduce Node.from_parent

1 files changed, 17 insertions, 0 deletions

diff --git a/testing/deprecated_test.py b/testing/deprecated_test.py
index 5390d038d..59cb69a00 100644
--- a/testing/deprecated_test.py
+++ b/testing/deprecated_test.py
@@ -1,5 +1,8 @@
+import inspect
+
 import pytest
 from _pytest import deprecated
+from _pytest import nodes
 
 
 @pytest.mark.filterwarnings("default")
@@ -73,3 +76,17 @@ def test_warn_about_imminent_junit_family_default_change(testdir, junit_family):
         result.stdout.no_fnmatch_line(warning_msg)
     else:
         result.stdout.fnmatch_lines([warning_msg])
+
+
+def test_node_direct_ctor_warning():
+    class MockConfig:
+        pass
+
+    ms = MockConfig()
+    with pytest.warns(
+        DeprecationWarning,
+        match="direct construction of .* has been deprecated, please use .*.from_parent",
+    ) as w:
+        nodes.Node(name="test", config=ms, session=ms, nodeid="None")
+    assert w[0].lineno == inspect.currentframe().f_lineno - 1
+    assert w[0].filename == __file__