issue 1496 - xfail with condition keyword

1 files changed, 13 insertions, 0 deletions

diff --git a/testing/test_skipping.py b/testing/test_skipping.py
index 194c8692b..2bfb6a8dc 100644
--- a/testing/test_skipping.py
+++ b/testing/test_skipping.py
@@ -405,6 +405,19 @@ class TestXFail:
         result.stdout.fnmatch_lines('*1 passed*')
         assert result.ret == 0
 
+    @pytest.mark.parametrize('strict', [True, False])
+    def test_xfail_condition_keyword(self, testdir, strict):
+        p = testdir.makepyfile("""
+            import pytest
+
+            @pytest.mark.xfail(condition=False, reason='unsupported feature', strict=%s)
+            def test_foo():
+                pass
+        """ % strict)
+        result = testdir.runpytest(p, '-rxX')
+        result.stdout.fnmatch_lines('*1 passed*')
+        assert result.ret == 0
+
     @pytest.mark.parametrize('strict_val', ['true', 'false'])
     def test_strict_xfail_default_from_file(self, testdir, strict_val):
         testdir.makeini('''