aboutsummaryrefslogtreecommitdiff
path: root/lib3
diff options
context:
space:
mode:
authorFlorian Bruhin <git@the-compiler.org>2018-06-27 14:50:15 +0200
committerIngy döt Net <ingy@ingy.net>2019-02-27 18:06:38 -0800
commit9959328b41ee577c6f14e3a0184b07dd0ecadb8c (patch)
treec7be6a00cc27b5053046f4c03ed850067441a13b /lib3
parentccc40f3e2ba384858c0d32263ac3e3a6626ab15e (diff)
downloadpyyaml-9959328b41ee577c6f14e3a0184b07dd0ecadb8c.tar.gz
Import Hashable from collections.abc
In Python 3.7, importing ABCs directly from the 'collections' module shows a warning (and in Python 3.8 it will stop working) - see https://github.com/python/cpython/commit/c66f9f8d3909f588c251957d499599a1680e2320 Since this is only done in lib3/ which is Python 3 only, we can unconditionally import it from collections.abc instead. This fixes the following DeprecationWarning: .../site-packages/yaml/__init__.py:75: in load return loader.get_single_data() .../site-packages/yaml/constructor.py:37: in get_single_data return self.construct_document(node) .../site-packages/yaml/constructor.py:46: in construct_document for dummy in generator: .../site-packages/yaml/constructor.py:398: in construct_yaml_map value = self.construct_mapping(node) .../site-packages/yaml/constructor.py:204: in construct_mapping return super().construct_mapping(node, deep=deep) .../site-packages/yaml/constructor.py:126: in construct_mapping if not isinstance(key, collections.Hashable): _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ name = 'Hashable' def __getattr__(name): # For backwards compatibility, continue to make the collections ABCs # through Python 3.6 available through the collections module. # Note, no new collections ABCs were added in Python 3.7 if name in _collections_abc.__all__: obj = getattr(_collections_abc, name) import warnings warnings.warn("Using or importing the ABCs from 'collections' instead " "of from 'collections.abc' is deprecated, " "and in 3.8 it will stop working", > DeprecationWarning, stacklevel=2) E DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
Diffstat (limited to 'lib3')
-rw-r--r--lib3/yaml/constructor.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib3/yaml/constructor.py b/lib3/yaml/constructor.py
index 981543a..193d91d 100644
--- a/lib3/yaml/constructor.py
+++ b/lib3/yaml/constructor.py
@@ -5,7 +5,7 @@ __all__ = ['BaseConstructor', 'SafeConstructor', 'Constructor',
from .error import *
from .nodes import *
-import collections, datetime, base64, binascii, re, sys, types
+import collections.abc, datetime, base64, binascii, re, sys, types
class ConstructorError(MarkedYAMLError):
pass
@@ -123,7 +123,7 @@ class BaseConstructor:
mapping = {}
for key_node, value_node in node.value:
key = self.construct_object(key_node, deep=deep)
- if not isinstance(key, collections.Hashable):
+ if not isinstance(key, collections.abc.Hashable):
raise ConstructorError("while constructing a mapping", node.start_mark,
"found unhashable key", key_node.start_mark)
value = self.construct_object(value_node, deep=deep)