From 73b1bb5fc6610177a605a2a1eaca3bf734ccd994 Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Tue, 24 Jul 2018 22:46:04 -0700 Subject: Fix PHONY target usage in robolectric coverage Phony targets should be labelled with .PHONY, real files should not depend on PHONY targets. Test: m RunSettingsRoboTests-coverage Test: m RunSettingsRoboTests-jacoco Test: add --writable=out/ to kati flags, see fewer warnings with this change Change-Id: I4796c7a3da806af81627fbc6fd00732fb2afb603 --- report-internal.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'report-internal.mk') diff --git a/report-internal.mk b/report-internal.mk index b9c60929b..fa0486760 100644 --- a/report-internal.mk +++ b/report-internal.mk @@ -13,7 +13,7 @@ $(my_coverage_output): PRIVATE_COVERAGE_REPORT_JAR := $(my_coverage_report_jar) $(my_coverage_output): PRIVATE_REPORT_DIR := $(my_report_dir) # Generate the coverage report. -$(my_coverage_output): $(my_collect_target) $(my_coverage_report_jar) +$(my_coverage_output): $(my_collect_file) $(my_coverage_report_jar) $(hide) rm -rf $(PRIVATE_REPORT_DIR) $(hide) mkdir -p $(PRIVATE_REPORT_DIR) $(hide) $(JAVA) \ @@ -46,4 +46,4 @@ $(my_target): $(my_coverage_output) # Reset local variables. my_coverage_output := my_coverage_output_zip := -my_report_dir := \ No newline at end of file +my_report_dir := -- cgit v1.2.3