aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Galenson <jgalenson@google.com>2021-08-17 19:16:57 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2021-08-17 19:16:57 +0000
commitc8bd0a03292db403daf0b00fb50b27b8dcd82332 (patch)
tree03acdaa9caf61638ffb0a6fd48056fe94589f17c
parent535647126dc95f2c2eaeceb47ac6f55cefb13ce6 (diff)
parenta1302f7a8beb79a534739a8e28cec294bc3086ff (diff)
downloadx509-parser-c8bd0a03292db403daf0b00fb50b27b8dcd82332.tar.gz
Use patch not feature to fix rustdoc build. am: a1302f7a8b
Original change: https://android-review.googlesource.com/c/platform/external/rust/crates/x509-parser/+/1798347 Change-Id: Icf973eabeb3ac424e103a2806a33ea41896400dd
-rw-r--r--Android.bp5
-rw-r--r--cargo2android.json1
-rw-r--r--patches/rustdoc.patch24
-rw-r--r--src/traits.rs13
4 files changed, 37 insertions, 6 deletions
diff --git a/Android.bp b/Android.bp
index 62fc34d..6d64e30 100644
--- a/Android.bp
+++ b/Android.bp
@@ -45,10 +45,7 @@ rust_library {
cargo_pkg_version: "0.10.0",
srcs: ["src/lib.rs"],
edition: "2018",
- features: [
- "default",
- "validate",
- ],
+ features: ["default"],
rustlibs: [
"libbase64_rust",
"libchrono",
diff --git a/cargo2android.json b/cargo2android.json
index e24b32a..5f001a6 100644
--- a/cargo2android.json
+++ b/cargo2android.json
@@ -3,7 +3,6 @@
"data_encoding"
],
"device": true,
- "features": "default,validate",
"run": true
}
diff --git a/patches/rustdoc.patch b/patches/rustdoc.patch
new file mode 100644
index 0000000..d6ec591
--- /dev/null
+++ b/patches/rustdoc.patch
@@ -0,0 +1,24 @@
+diff --git a/src/traits.rs b/src/traits.rs
+index bd4d070..aae96e5 100644
+--- a/src/traits.rs
++++ b/src/traits.rs
+@@ -5,7 +5,18 @@ use crate::error::X509Result;
+ ///
+ /// The returned object uses zero-copy, and so has the same lifetime as the input.
+ ///
+-/// Note that only parsing is done, not validation (see the [`Validate`](crate::validate::Validate) trait).
++#[cfg_attr(
++ feature = "validate",
++ doc = r#"
++Note that only parsing is done, not validation (see the [`Validate`](crate::validate::Validate) trait).
++"#
++)]
++#[cfg_attr(
++ not(feature = "validate"),
++ doc = r#"
++Note that only parsing is done, not validation.
++"#
++)]
+ ///
+ /// # Example
+ ///
diff --git a/src/traits.rs b/src/traits.rs
index bd4d070..aae96e5 100644
--- a/src/traits.rs
+++ b/src/traits.rs
@@ -5,7 +5,18 @@ use crate::error::X509Result;
///
/// The returned object uses zero-copy, and so has the same lifetime as the input.
///
-/// Note that only parsing is done, not validation (see the [`Validate`](crate::validate::Validate) trait).
+#[cfg_attr(
+ feature = "validate",
+ doc = r#"
+Note that only parsing is done, not validation (see the [`Validate`](crate::validate::Validate) trait).
+"#
+)]
+#[cfg_attr(
+ not(feature = "validate"),
+ doc = r#"
+Note that only parsing is done, not validation.
+"#
+)]
///
/// # Example
///