diff options
author | Dominic Chen <ddchen@apple.com> | 2022-04-19 01:56:07 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2022-04-19 01:56:07 +0000 |
commit | 3c6d2d120c74d2069f0c87cb7ad07269324d6bb2 (patch) | |
tree | 05aae419125bd7a0f175838d1eb528230aea3fea | |
parent | 81d0a55e20eed47e6e0fb68b2d4b16a15fd897c2 (diff) | |
parent | e987d14bbe5696b8382a0cebd2e619974b7058e3 (diff) | |
download | scudo-3c6d2d120c74d2069f0c87cb7ad07269324d6bb2.tar.gz |
Revert "[scudo] Wrap clang pragma to avoid GCC error" am: 99755b0ed5 am: 6efe5e781c am: 94369c99a5 am: c44a9e1656 am: e987d14bbe
Original change: https://android-review.googlesource.com/c/platform/external/scudo/+/2066955
Change-Id: Id053fc9af362118af2051218d27d824ee5ffac05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r-- | standalone/memtag.h | 31 |
1 files changed, 13 insertions, 18 deletions
diff --git a/standalone/memtag.h b/standalone/memtag.h index 966bf6b9ee2..df346bce1bd 100644 --- a/standalone/memtag.h +++ b/standalone/memtag.h @@ -41,16 +41,16 @@ inline uint8_t extractTag(uptr Ptr) { return (Ptr >> 56) & 0xf; } inline constexpr bool archSupportsMemoryTagging() { return false; } -inline NORETURN uptr archMemoryTagGranuleSize() { +inline uptr archMemoryTagGranuleSize() { UNREACHABLE("memory tagging not supported"); } -inline NORETURN uptr untagPointer(uptr Ptr) { +inline uptr untagPointer(uptr Ptr) { (void)Ptr; UNREACHABLE("memory tagging not supported"); } -inline NORETURN uint8_t extractTag(uptr Ptr) { +inline uint8_t extractTag(uptr Ptr) { (void)Ptr; UNREACHABLE("memory tagging not supported"); } @@ -109,11 +109,11 @@ inline void enableSystemMemoryTaggingTestOnly() { inline bool systemSupportsMemoryTagging() { return false; } -inline NORETURN bool systemDetectsMemoryTagFaultsTestOnly() { +inline bool systemDetectsMemoryTagFaultsTestOnly() { UNREACHABLE("memory tagging not supported"); } -inline NORETURN void enableSystemMemoryTaggingTestOnly() { +inline void enableSystemMemoryTaggingTestOnly() { UNREACHABLE("memory tagging not supported"); } @@ -255,15 +255,15 @@ inline uptr loadTag(uptr Ptr) { #else -inline NORETURN bool systemSupportsMemoryTagging() { +inline bool systemSupportsMemoryTagging() { UNREACHABLE("memory tagging not supported"); } -inline NORETURN bool systemDetectsMemoryTagFaultsTestOnly() { +inline bool systemDetectsMemoryTagFaultsTestOnly() { UNREACHABLE("memory tagging not supported"); } -inline NORETURN void enableSystemMemoryTaggingTestOnly() { +inline void enableSystemMemoryTaggingTestOnly() { UNREACHABLE("memory tagging not supported"); } @@ -271,46 +271,41 @@ struct ScopedDisableMemoryTagChecks { ScopedDisableMemoryTagChecks() {} }; -inline NORETURN uptr selectRandomTag(uptr Ptr, uptr ExcludeMask) { +inline uptr selectRandomTag(uptr Ptr, uptr ExcludeMask) { (void)Ptr; (void)ExcludeMask; UNREACHABLE("memory tagging not supported"); } -inline NORETURN uptr addFixedTag(uptr Ptr, uptr Tag) { +inline uptr addFixedTag(uptr Ptr, uptr Tag) { (void)Ptr; (void)Tag; UNREACHABLE("memory tagging not supported"); } -inline NORETURN uptr storeTags(uptr Begin, uptr End) { +inline uptr storeTags(uptr Begin, uptr End) { (void)Begin; (void)End; UNREACHABLE("memory tagging not supported"); } -inline NORETURN void storeTag(uptr Ptr) { +inline void storeTag(uptr Ptr) { (void)Ptr; UNREACHABLE("memory tagging not supported"); } -inline NORETURN uptr loadTag(uptr Ptr) { +inline uptr loadTag(uptr Ptr) { (void)Ptr; UNREACHABLE("memory tagging not supported"); } #endif -#if __clang__ -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wmissing-noreturn" inline void setRandomTag(void *Ptr, uptr Size, uptr ExcludeMask, uptr *TaggedBegin, uptr *TaggedEnd) { *TaggedBegin = selectRandomTag(reinterpret_cast<uptr>(Ptr), ExcludeMask); *TaggedEnd = storeTags(*TaggedBegin, *TaggedBegin + Size); } -#pragma clang diagnostic pop -#endif inline void *untagPointer(void *Ptr) { return reinterpret_cast<void *>(untagPointer(reinterpret_cast<uptr>(Ptr))); |