aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHaibo Huang <hhb@google.com>2019-05-06 12:43:47 -0700
committerandroid-build-team Robot <android-build-team-robot@google.com>2019-05-14 04:56:54 +0000
commit505d1d117865ee5261b91c3555c0c71a757e5cf3 (patch)
tree5a317d80317cd5b3b88baeeeabc8aaf78107f3e7
parent0bad802dc17fc283171923479960d6dab6342d3c (diff)
downloadsfntly-505d1d117865ee5261b91c3555c0c71a757e5cf3.tar.gz
Fix uninitialized value in sfntly
Bug: 116114182 Test: build Change-Id: Ief84dd8a19bdb461945e07504270be76a3545701 Merged-In: Ief84dd8a19bdb461945e07504270be76a3545701 (cherry picked from commit 51ecc82faa63aacdde6648f80a3898b53653da78)
-rw-r--r--README.android4
-rw-r--r--cpp/src/sfntly/port/file_input_stream.cc2
2 files changed, 5 insertions, 1 deletions
diff --git a/README.android b/README.android
index 4447b27..39b0cf9 100644
--- a/README.android
+++ b/README.android
@@ -9,3 +9,7 @@ git rm -rf cpp/data
git rm -rf cpp/ext
git rm -rf cpp/tools
git commit
+
+
+# Local changes
+Fixed uninitialized variable. See bug 116114182 for details.
diff --git a/cpp/src/sfntly/port/file_input_stream.cc b/cpp/src/sfntly/port/file_input_stream.cc
index dfe9a7b..883c1fd 100644
--- a/cpp/src/sfntly/port/file_input_stream.cc
+++ b/cpp/src/sfntly/port/file_input_stream.cc
@@ -70,7 +70,7 @@ int32_t FileInputStream::Read() {
#endif
return 0;
}
- byte_t value;
+ byte_t value = 0;
size_t length = fread(&value, 1, 1, file_);
position_ += length;
return value;