Added unit test for underscoreName(), and fixed potential POSIX compliance issue.

2 files changed, 14 insertions, 3 deletions

diff --git a/shflags b/shflags
index 672ac39..c8dd5fe 100644
--- a/shflags
+++ b/shflags
@@ -427,7 +427,7 @@ _flags_define() {
 # Output:
 #   string: underscored name
 _flags_underscoreName() {
-  echo "$1" |tr '-' '_'
+  echo "$1" |tr z- z_
 }
 
 # Return valid getopt options using currently defined list of long options.
diff --git a/shflags_private_test.sh b/shflags_private_test.sh
index 5a2b442..e6b6376 100755
--- a/shflags_private_test.sh
+++ b/shflags_private_test.sh
@@ -3,8 +3,7 @@
 #
 # shFlags unit tests for the internal functions.
 #
-#
-# Copyright 2008-2017 Kate Ward. All Rights Reserved.
+# Copyright 2008-2018 Kate Ward. All Rights Reserved.
 # Released under the Apache 2.0 license.
 #
 # Author: kate.ward@forestent.com (Kate Ward)
@@ -113,6 +112,18 @@ EOF
   assertFalse 'empty lists should not match' $?
 }
 
+testUnderscoreName() {
+  while read desc name want; do
+    got=`_flags_underscoreName "${name}"`
+    assertEquals "${desc}: underscoreName(${name})" "${got}" "${want}"
+  done <<EOF
+with_dashes        name-with-dashes      name_with_dashes
+with_underscores   name_with_underscores name_with_underscores
+just_alpha_numeric abc123                abc123
+empty              ""                    ""
+EOF
+}
+
 testValidBool() {
   # Valid values.
   for value in ${TH_BOOL_VALID}; do