diff options
author | Ravi Mistry <rmistry@google.com> | 2019-03-21 10:21:35 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2019-04-23 15:01:56 +0000 |
commit | 4c4a47e5607b5191cd3360071e8b293859391331 (patch) | |
tree | d2f7e498b1a30985990187423306aa2681330a87 | |
parent | 1d5fbca96161aa771ecf84a3de535caf98f6a1a8 (diff) | |
download | skia-4c4a47e5607b5191cd3360071e8b293859391331.tar.gz |
Remove auto adding CQ keywords for non-master branches
Bug: skia:
Change-Id: I03e5ceff326d38f96ce6fea699248b0232e39a63
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202701
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
(cherry picked from commit 6bb809a60530b8e05e1f0b0cbfa4a9e614cc5697)
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209820
-rw-r--r-- | PRESUBMIT.py | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 0cf5acb3e2..bd3d31e5cf 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -441,12 +441,6 @@ def PostUploadHook(cl, change, output_api): This hook does the following: * Adds a link to preview docs changes if there are any docs changes in the CL. * Adds 'No-Try: true' if the CL contains only docs changes. - * Adds 'No-Tree-Checks: true' for non master branch changes since they do not - need to be gated on the master branch's tree. - * Adds 'No-Try: true' for non master branch changes since trybots do not yet - work on them. - * Adds 'No-Presubmit: true' for non master branch changes since those don't - run the presubmit checks. """ results = [] @@ -496,30 +490,6 @@ def PostUploadHook(cl, change, output_api): 'Automatically added a link to preview the docs changes to the ' 'CL\'s description')) - # If the target ref is not master then add 'No-Tree-Checks: true' and - # 'No-Try: true' to the CL's description if it does not already exist there. - target_ref = cl.GetRemoteBranch()[1] - if target_ref != 'refs/remotes/origin/master': - if not _FooterExists(footers, 'No-Tree-Checks', 'true'): - new_description_lines.append('No-Tree-Checks: true') - results.append( - output_api.PresubmitNotifyResult( - 'Branch changes do not need to rely on the master branch\'s ' - 'tree status. Automatically added \'No-Tree-Checks: true\' to ' - 'the CL\'s description')) - if not _FooterExists(footers, 'No-Try', 'true'): - new_description_lines.append('No-Try: true') - results.append( - output_api.PresubmitNotifyResult( - 'Trybots do not yet work for non-master branches. ' - 'Automatically added \'No-Try: true\' to the CL\'s ' - 'description')) - if not _FooterExists(footers, 'No-Presubmit', 'true'): - new_description_lines.append('No-Presubmit: true') - results.append( - output_api.PresubmitNotifyResult( - 'Branch changes do not run the presubmit checks.')) - # If the description has changed update it. if new_description_lines != original_description_lines: # Add a new line separating the new contents from the old contents. |