diff options
| author | senorblanco <senorblanco@chromium.org> | 2014-06-12 11:24:19 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-06-12 11:24:20 -0700 |
| commit | ce6a354e121915c2925e545e7df2929492d69d50 (patch) | |
| tree | 0d402dcd9fb7e585254f3dcd43051b7d532e3c93 /expectations | |
| parent | e61c411c1258a323a010558c08de3d9f8d170dca (diff) | |
| download | skia-ce6a354e121915c2925e545e7df2929492d69d50.tar.gz | |
Fix tiled perlin noise.
It turns out that the perlin implementation we inherited from WebKit
does not actually generate tileable noise (see Chromium bug
http://crbug.com/383495).
The main problem is that when generating coordinates for gradient
interpolation, it was attempting to wrap both x and (x + 1)
simultaneously at the tile boundary (that is, either both or neither
are wrapped). This obviously won't work, since along the tile seams,
(x + 1) should be wrapped, but x should not. The same is true in y.
This patch fixes both the CPU and GPU paths, renames some variables to
more closely match the spec, and modifies the perlin noise GM to
actually test tiling. (Note that the clipping the GM was doing was
removed, since it's superfluous: it used to be necessary for image
filters, but isn't anymore, and this isn't an image filter GM anyway.)
R=sugoi@google.com, sugoi
TBR=senorblanco
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/332523006
Diffstat (limited to 'expectations')
| -rw-r--r-- | expectations/gm/ignored-tests.txt | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/expectations/gm/ignored-tests.txt b/expectations/gm/ignored-tests.txt index 573593bca6..9d6ce3ee31 100644 --- a/expectations/gm/ignored-tests.txt +++ b/expectations/gm/ignored-tests.txt @@ -78,3 +78,7 @@ dashcubics # dandov: Fix for bitmap shader by taking into account if the bitmap is alpha only # https://codereview.chromium.org/318923005/ bitmapshaders + +# Added by senorblanco for https://codereview.chromium.org/332523006/ +# Needs rebaseline for modified test cases +perlinnoise |