diff options
| author | John Stiles <johnstiles@google.com> | 2021-06-24 18:05:10 -0400 |
|---|---|---|
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2021-06-25 11:05:59 +0000 |
| commit | e58831cd9578805634b986b434a20757277b3a36 (patch) | |
| tree | c667982cc4c74753b4419fbd71ce019d3d974bba /src/core/SkTextBlobTrace.cpp | |
| parent | 3a35f0b263cbdad011ffff6e5032f5996e946239 (diff) | |
| download | skia-e58831cd9578805634b986b434a20757277b3a36.tar.gz | |
Add format-specifier warnings to SkDebugf.
This CL fixes up many existing format-specifier violations in Skia.
Note that GCC has a warning for formatting nothing, so existing calls to
`SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
These were apparently meant to be used as a place to set a breakpoint.
Some of our clients also use SkDebug with bad format specifiers, so this
check is currently only enabled when SKIA_IMPLEMENTATION is true.
Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Diffstat (limited to 'src/core/SkTextBlobTrace.cpp')
| -rw-r--r-- | src/core/SkTextBlobTrace.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/SkTextBlobTrace.cpp b/src/core/SkTextBlobTrace.cpp index 7cd15e3387..88275427a6 100644 --- a/src/core/SkTextBlobTrace.cpp +++ b/src/core/SkTextBlobTrace.cpp @@ -63,8 +63,8 @@ void SkTextBlobTrace::DumpTrace(const std::vector<SkTextBlobTrace::Record>& trac font.getScaleX(), font.getSkewX(), SkFontPriv::Flags(font), - font.getEdging(), - font.getHinting()); + (int)font.getEdging(), + (int)font.getHinting()); uint32_t glyphCount = iter.glyphCount(); const uint16_t* glyphs = iter.glyphs(); for (uint32_t i = 0; i < glyphCount; i++) { |