aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-02-28Fix baseFrequencyY calculation again.John Stiles
Copy-paste error; not caught by tests because the existing test used square tiles. Bug: b/40045243 Change-Id: I67a91e950deca48f3be377b82c383d87fb2b6c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/820117 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2024-02-28Use a VMA block size of only 64kLeon Scroggins III
Using 64KB (down from 4MB) has been found to reduce memory usage without negatively affecting performance. Bug: 326515473 Bug: 321962001 Change-Id: Ie6eb57b7d534109ddce29412c88da549a4bf2624 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819796 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Auto-Submit: Leon Scroggins <scroggo@google.com>
2024-02-28Fix wireframe mode in GrTriangulator.Stephen White
In https://skia-review.googlesource.com/c/skia/+/279236, TESSELLATOR_WIREFRAME was renamed TRIANGULATOR_WIREFRAME but this use of it was missed. (This is only used for debugging, but nice when it works.) Change-Id: I20f486e11213dc96f848a52485960659c1dd1772 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/820136 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Auto-Submit: Stephen White <senorblanco@chromium.org>
2024-02-28Fix base frequency of stitched Perlin noise.John Stiles
During noise stitching, the base frequency values are adjusted to fall on exact tile boundaries. This happens inside PaintingData::stitch. The top-level Perlin noise class never updates its values to match, though, so we need to rely on the PaintingData numbers when rendering. This is tested by Chrome in feTurbulence-tiled.svg: http://screen/3E4ZouYTC73oocy I'll update Skia's tests to include something similar. Bug: b/40045243 Change-Id: I6c00ff53325e1b3e86864fd2e86f050d9e0da87f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/820116 Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2024-02-28Re-enable tracing when building for Android frameworkNolan Scobie
Follow up to accidental disablement from Ic608a59ea8512106b0355e9c857f269eea8796ce Bug: b/327261693 Change-Id: I5f5fb741f4b800808767ec7c9447383c3ea7b0ac Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819797 Auto-Submit: Nolan Scobie <nscobie@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2024-02-28[graphite] Add missing failure callback in QueueManager::addRecordingNolan Scobie
... for recordings being replayed out of order. Note: I have not encountered this failure, I just noticed the discrepancy when passing by. Please validate that I'm not misunderstanding. Change-Id: I8462a70c4ca80695856eb7927ec2c8f863673c5e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819696 Reviewed-by: Nicolette Prevost <nicolettep@google.com> Commit-Queue: Nicolette Prevost <nicolettep@google.com> Auto-Submit: Nolan Scobie <nscobie@google.com>
2024-02-28[graphite] Minor DrawAtlas cleanup.Jim Van Verth
Mainly removing some duplicated code and placing related things together Change-Id: I82c514a5c2430ac37bc80a6b730f869042bdb3a7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819697 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2024-02-28Manual roll Dawn from 11b95ad3e8f7 to aa0be6f5777f (2 revisions)skia-autoroll
Manual roll requested by robertphillips@google.com https://dawn.googlesource.com/dawn.git/+log/11b95ad3e8f7..aa0be6f5777f 2024-02-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 98117d395c2e to 89977a07f1c3 (9 revisions) 2024-02-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2fb425d2847f to a627dd89762e (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,dsinclair@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: dsinclair@google.com,robertphillips@google.com Change-Id: I9fbad2991fc2f43c9ee932f3bf0e549e48a02bbc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819976 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-28Manual roll vulkan-deps from 64550d191409 to 83c3be5d8216 (4 revisions)skia-autoroll
Manual roll requested by robertphillips@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/64550d191409..83c3be5d8216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC robertphillips@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: robertphillips@google.com Change-Id: I70ad32bc2e6d5de98e5840eb850a806e3c054d0f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819957 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-28Revert "Cleanup linkage in SkSwizzler_opts.h"Robert Phillips
This reverts commit 21a4051583917068f6813a35dc84cd036b25396a. Reason for revert: May be blocking Chrome roll Original change's description: > Cleanup linkage in SkSwizzler_opts.h > > * Add the SI macro from RasterPipeline _opts, and use it. > * Remove /* not static */ inline from the main entry points of > the file. > * Add a system for overriding SK_OPTS_NS for testing. > * Change SkSwizzler_opts.h to .inc to avoid incorrect tidy warnings. > The .inc suffix is spec in Google3 style guide: > go/cstyle#File_Names > > SkSwizzler_opts.inc is included in three different places and is > controlled by three different SK_OPTS_TARGET settings. > * SkSwizzler_opts_ssse3.cpp & SK_OPTS_TARGET_SSSE3 - creates > optimizations specific to x86_64 SSSE3 instruction set. > * SkSwizzler_opts_hsw.cpp & SK_OPTS_TARGET_HSW - creates > optimizations for x86_64 Haswell architecture or latter. AVX2 is > the main architectural feature enabled. > * SkSwizzler_opts.cpp & SK_OPTS_TARGET_DEFAULT - creates the base > level optimizations used. SkOpts_SetTarget discovers the > architectural features enabled, and sets the proper #defines. For > x86_64 this is what level of SIMD instructions is support, and > for ARM it detects if NEON is supported. > > SkOpts_SetTarget also sets the #define SK_OPTS_NS to the unique > namespace for this code. > > Change-Id: I6606dcdfabe986ce10c95a9b3ea6485e445d1362 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819676 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: Herb Derby <herb@google.com> Change-Id: Ifac2b28753a8b3ec703b8e2a62a0a1c4d1532141 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819814 Auto-Submit: Robert Phillips <robertphillips@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2024-02-28Roll ANGLE from 2fb425d2847f to a627dd89762e (4 revisions)skia-autoroll
https://chromium.googlesource.com/angle/angle.git/+log/2fb425d2847f..a627dd89762e 2024-02-27 bsheedy@chromium.org Revert "Vulkan: Feature addition for QCOM foveated rendering extensions" 2024-02-27 liza@chromium.org Create ImageHelper. 2024-02-27 lexa.knyazev@gmail.com Update cached component type masks on attachment redefinitions 2024-02-27 mark@lunarg.com Context: Limit max vtx uniform vectors to 256 during capture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: robertphillips@google.com Change-Id: I803cba663d1685bd17f9958d451bdc78ff89da41 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819505 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-28Cleanup linkage in SkSwizzler_opts.hHerb Derby
* Add the SI macro from RasterPipeline _opts, and use it. * Remove /* not static */ inline from the main entry points of the file. * Add a system for overriding SK_OPTS_NS for testing. * Change SkSwizzler_opts.h to .inc to avoid incorrect tidy warnings. The .inc suffix is spec in Google3 style guide: go/cstyle#File_Names SkSwizzler_opts.inc is included in three different places and is controlled by three different SK_OPTS_TARGET settings. * SkSwizzler_opts_ssse3.cpp & SK_OPTS_TARGET_SSSE3 - creates optimizations specific to x86_64 SSSE3 instruction set. * SkSwizzler_opts_hsw.cpp & SK_OPTS_TARGET_HSW - creates optimizations for x86_64 Haswell architecture or latter. AVX2 is the main architectural feature enabled. * SkSwizzler_opts.cpp & SK_OPTS_TARGET_DEFAULT - creates the base level optimizations used. SkOpts_SetTarget discovers the architectural features enabled, and sets the proper #defines. For x86_64 this is what level of SIMD instructions is support, and for ARM it detects if NEON is supported. SkOpts_SetTarget also sets the #define SK_OPTS_NS to the unique namespace for this code. Change-Id: I6606dcdfabe986ce10c95a9b3ea6485e445d1362 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819676 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Herb Derby <herb@google.com>
2024-02-28Roll SK Tool from 1ce4523589b0 to 22671d61de6cskia-autoroll
https://skia.googlesource.com/buildbot.git/+log/1ce4523589b0..22671d61de6c 2024-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 34f900647879 to 1ce4523589b0 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/sk-tool-skia Please CC rmistry@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: rmistry@google.com Change-Id: I56bcbc4be38759c6a17b4a97014b9f891693f78b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819506 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-28Roll Skia Infra from 34f900647879 to 1ce4523589b0 (7 revisions)skia-autoroll
https://skia.googlesource.com/buildbot.git/+log/34f900647879..1ce4523589b0 2024-02-28 lovisolo@google.com [gold] Enable debugging endpoints for all frontend and baseline server instances. 2024-02-27 ashwinpv@google.com Specify the bug host in instance config for rendering bug links on the anomaly-sk 2024-02-27 viditchitkara@google.com [bisect] Implement benchmark test type lacros telemetry 2024-02-27 haowoo@google.com Enable SingleCommitRunner workflow. 2024-02-27 haowoo@google.com Add SingleCommitRunner workflow. 2024-02-27 sunxiaodi@google.com [pinpoint] remove excess parameters from compare function calls 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from dd4b27ecbb53 to 34f900647879 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC rmistry@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: rmistry@google.com Change-Id: Ib22362dc2716b1e5dd9e472122a843677dbb072d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819876 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-28Roll Dawn from 7b482f48e635 to 11b95ad3e8f7 (8 revisions)skia-autoroll
https://dawn.googlesource.com/dawn.git/+log/7b482f48e635..11b95ad3e8f7 2024-02-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 696a13a2a8d0 to 5a3178590581 (3 revisions) 2024-02-28 amaiorano@google.com tint: work around zero-init bug on some GPUs for workgroup size(1) 2024-02-28 bclayton@google.com [tint][wgsl] RenameConflicts: Ensure types can be resolved. 2024-02-28 bclayton@google.com [tint] Implement support for r8unorm 2024-02-28 bclayton@google.com [tint] Add support for scoped text spans 2024-02-27 dsinclair@chromium.org Triage some expectations. 2024-02-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc25d8806a33 to 98117d395c2e (6 revisions) 2024-02-27 dsinclair@chromium.org Roll third_party/webgpu-cts/ 559c806e5..62389bc77 (29 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: dsinclair@google.com Change-Id: I235a2fae671f69ae6118eb300296d06722de839b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819663 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-28Roll vulkan-deps from 32b3df0d7dd6 to 64550d191409 (8 revisions)skia-autoroll
https://chromium.googlesource.com/vulkan-deps.git/+log/32b3df0d7dd6..64550d191409 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/99a3ad32ffbf35797ca079537940bb5c870ebaaf..fbc7a14b3e5e494113a464bbfafc48b94516446a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC robertphillips@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: robertphillips@google.com Change-Id: Ie26036ddda5e2aed648c7e7ac744b7a2a5b7e73e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819504 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27[graphite] RasterPathAtlas and SmallPathAtlas fixes.Jim Van Verth
We're addressing two issues here. First, SmallPathAtlas was not adding the padding required by CoverageMaskRenderStep. Second, in both RasterPathAtlas and SmallPathAtlas we no longer run the path through the stroker and then cache based on the resulting path. Instead we render directly using the StrokeRec, so we need to store the full StrokeRec information into the cache key. Bug: b/294378744 Change-Id: If35e294d5daca51eb6f101a0d6480e40b715f44c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819716 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2024-02-27Guard SkPerlinNoiseShader::onMakeContext with our new flag.John Stiles
I had forgotten than `makeContext` is preferred over `appendStages` in SkBlitter::Choose when both paths exist. Now both calls are flag-guarded. After this rolls into Chrome, I will attempt to rebaseline again using https://crrev.com/c/5323882. Bug: b/40045243 Change-Id: I7dd9588eb824bde8c0b8d20919ed7c7fb574889c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819678 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2024-02-27Fix turbulence calculation in RP Perlin noise.John Stiles
The abs() function was being called at the wrong point. Bug: b/40045243 Change-Id: Ia2dfc3b26937bc057d1460e0007cfffb101de138 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819643 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2024-02-27Roll Skia from e10b290898a2 to 170fbb029e61 (6 revisions)android-autoroll
https://skia.googlesource.com/skia.git/+log/e10b290898a2..170fbb029e61 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from f0af4730d927 to 2fb425d2847f (3 revisions) 2024-02-27 jvanverth@google.com [graphite] Break out rect management in DrawAtlas. 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 996ab52aeac4 to 7b482f48e635 (2 revisions) 2024-02-27 johnstiles@google.com Revert "Delete legacy shadeSpan implementation of Perlin Noise." 2024-02-27 jvanverth@google.com Revert "[graphite] Enable SmallPathAtlas." 2024-02-27 jlavrova@google.com Reland "Implementing Fontations font scanner" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/android-master-autoroll Please CC djsollen@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/294378744 Bug: b/40045243 Bug: b/186777432 Change-Id: I80174431b98f65c52bcb0a035ce9adbfbc7f110c
2024-02-27Manual roll ANGLE from f0af4730d927 to 2fb425d2847f (3 revisions)skia-autoroll
Manual roll requested by robertphillips@google.com https://chromium.googlesource.com/angle/angle.git/+log/f0af4730d927..2fb425d2847f 2024-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd6c2371c85d to 28960bf4a098 (10 revisions) 2024-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0f69b790c7a4 to bbe6452b420c (1 revision) 2024-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 16b5225bad88 to cc3c5664ec19 (580 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: robertphillips@google.com Change-Id: I1fc543ab392a4d2622182bc28f362a0bb06083b8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819657 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27[graphite] Break out rect management in DrawAtlas.Jim Van Verth
Adds a new method addRect() which will try to reserve a rectangular region in the DrawAtlas, updating the Rectanizer but not adding any data. This will allow the RasterPathAtlas to rasterize directly to that region in the DrawAtlas instead of having to copy already rasterized data via addToAtlas(). Bug: b/294378744 Change-Id: I793b835b94a5f252f003b1fb886c03c28e25b95f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818896 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Herb Derby <herb@google.com>
2024-02-27Manual roll Dawn from 996ab52aeac4 to 7b482f48e635 (2 revisions)skia-autoroll
Manual roll requested by robertphillips@google.com https://dawn.googlesource.com/dawn.git/+log/996ab52aeac4..7b482f48e635 2024-02-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3c517e457a45 to 2fb425d2847f (6 revisions) 2024-02-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 1a48b86e08c1 to 696a13a2a8d0 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,dsinclair@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: dsinclair@google.com,robertphillips@google.com Change-Id: I15212602cfdad23027a8178c586140984fd84e23 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819656 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Revert "Delete legacy shadeSpan implementation of Perlin Noise."John Stiles
This reverts commit 8589595721d09bd54ca694f75263846f400096da. Reason for revert: output visibly different Original change's description: > Delete legacy shadeSpan implementation of Perlin Noise. > > A CL was set up to rebaseline Chrome at https://crrev.com/c/5323882, > but it came up with zero image errors. > > Bug: b/40045243 > Change-Id: I9c0ae2920ebaf56dcb931a57317ad2de0553d8f0 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/817622 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> Bug: b/40045243 Change-Id: I07e8e6abdadfa64693c18decd075a46fbee0e231 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819520 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2024-02-27Revert "[graphite] Enable SmallPathAtlas."Jim Van Verth
This reverts commit 87c2058eba6c4deadf076781e5e6565c6b4e4884. Reason for revert: Causing asserts in Chrome tests Original change's description: > [graphite] Enable SmallPathAtlas. > > Uses the transformed and conservatively clipped path bounds to > determine whether a path is small enough to be stored in this atlas > rather than the RasterPathAtlas. > > Also fixes some minor bugs in initialization and sets up atlas > compaction. > > Bug: b/294378744 > Change-Id: I6d9b71b5737bc39809e51a22aa037be51775f144 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/816558 > Reviewed-by: Arman Uguray <armansito@google.com> > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> Bug: b/294378744 Change-Id: I73a99f7d69f3657171f48c465a247f8cf9c5c4b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819458 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2024-02-27Reland "Implementing Fontations font scanner"Julia Lavrova
This is a reland of commit 432b4e0a854bb6bb3fe66b9fc41e3a98c5bc6d55 Original change's description: > Implementing Fontations font scanner > > (using Fontations font scanner for Android font mgr) > FontStyle added > Reading font/collection added > > Change-Id: I4036acf8420583700c9ab108d40eed585dfbfd9b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/799417 > Commit-Queue: Julia Lavrova <jlavrova@google.com> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> > Reviewed-by: Florin Malita <fmalita@google.com> Change-Id: Ia96a1a3b9bd4e5bb4dcfefe4cef4319465ed6fd7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/817796 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com>
2024-02-27Roll Skia from 2d46dae4a91e to e10b290898a2 (5 revisions)android-autoroll
https://skia.googlesource.com/skia.git/+log/2d46dae4a91e..e10b290898a2 2024-02-27 johnstiles@google.com Manually roll Dawn to the latest version. 2024-02-27 johnstiles@google.com Delete legacy shadeSpan implementation of Perlin Noise. 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc25d8806a33 to 32b3df0d7dd6 (5 revisions) 2024-02-27 kjlubick@google.com Minor clang tidy/format fixes 2024-02-27 michaelludwig@google.com Reland "[skif] Add transparent padding to source saveLayers" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/android-master-autoroll Please CC djsollen@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/323886195 Bug: b/40045243 Bug: b/186777432 Change-Id: Ib5be0da2482af266af9403d69c58493f8b0f4442
2024-02-27Manually roll Dawn to the latest version.John Stiles
The automatic rolls were failing for two reasons: - The diagnostic Format() API changed its return type - Warning text has changed; there are more apostrophes around names from the code. Change-Id: Ida72bc8df0eb3d3b6eac38152ad12ee879f855ce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819457 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2024-02-27Delete legacy shadeSpan implementation of Perlin Noise.John Stiles
A CL was set up to rebaseline Chrome at https://crrev.com/c/5323882, but it came up with zero image errors. Bug: b/40045243 Change-Id: I9c0ae2920ebaf56dcb931a57317ad2de0553d8f0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/817622 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2024-02-27Roll vulkan-deps from cc25d8806a33 to 32b3df0d7dd6 (5 revisions)skia-autoroll
https://chromium.googlesource.com/vulkan-deps.git/+log/cc25d8806a33..32b3df0d7dd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC robertphillips@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: robertphillips@google.com Change-Id: If16819d9925404eaef860f09e8102ba6f495b64a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819496 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Minor clang tidy/format fixesK Lubick
Change-Id: Ice2d0b391a531ee2433df0c072d7ec50be8439dd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818897 Auto-Submit: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nicolette Prevost <nicolettep@google.com> Commit-Queue: Nicolette Prevost <nicolettep@google.com>
2024-02-27Reland "[skif] Add transparent padding to source saveLayers"Michael Ludwig
This reverts commit 60b39c417a65e7c28354d9ddb4792f91791942d9. Reason for revert: fixed guard in drawDevice() for flutter since SK_RESOLVE_FILTERS_BEFORE_RESTORE blocks the transparent padding too. Makes insetForSaveLayer() not crash on null images. Original change's description: > Revert "[skif] Add transparent padding to source saveLayers" > > This reverts commit 74661f1ccf74f7d1d243ccfff505f5355774b998. > > Reason for revert: breaking Flutter roll > > Original change's description: > > [skif] Add transparent padding to source saveLayers > > > > Bug: b/323886195 > > Change-Id: I29bcdf6832ebe53f816764438b3d0017909bdafd > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/813016 > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Reviewed-by: Brian Osman <brianosman@google.com> > > Bug: b/323886195 > Change-Id: Iae3e5bb6fdf4d8fb8bf710384c9152f77da3275d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818976 > Auto-Submit: John Stiles <johnstiles@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: b/323886195 Change-Id: I72452752b646d3f689f4755798380c3afadd6e10 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819156 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2024-02-27Roll Skia from d5ca52bc7739 to 2d46dae4a91e (2 revisions)android-autoroll
https://skia.googlesource.com/skia.git/+log/d5ca52bc7739..2d46dae4a91e 2024-02-27 kjlubick@google.com Enforce IWYU on skottie and sksg 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from acba61cb3e27 to f0af4730d927 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/android-master-autoroll Please CC djsollen@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/186777432 Change-Id: If97994c6f01c4819a24a248eabed3377a775c162
2024-02-27Enforce IWYU on skottie and sksgK Lubick
While using these modules in G3, I ran into a few cases where missing #includes caused problems, so I decided to enforce IWYU on the entirety of both modules. A few non-Skottie files also needed updating as a result or in unrelated but similar errors. Change-Id: I453afd156291136dc8d9acebb68512a78eb64e36 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818104 Auto-Submit: Kevin Lubick <kjlubick@google.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2024-02-27Roll ANGLE from acba61cb3e27 to f0af4730d927 (10 revisions)skia-autoroll
https://chromium.googlesource.com/angle/angle.git/+log/acba61cb3e27..f0af4730d927 2024-02-27 syoussefi@chromium.org Vulkan: Catch misuse of AddToPNextChain 2024-02-27 m.maiya@samsung.com Vulkan: Feature addition for QCOM foveated rendering extensions 2024-02-27 gman@chromium.org Handle count = 0 in DrawElementsIndirect 2024-02-26 abdolrashidi@google.com Vulkan: Process ClearEmulatedChannels update first 2024-02-26 abdolrashidi@google.com Vulkan: Update flushStagedUpdate to use switchcase 2024-02-26 victor@haleytek.com Fix build error when git history not fully available 2024-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from d15e5faec700 to d023c17ac299 (1 revision) 2024-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 602ab4120d74 to dd6c2371c85d (8 revisions) 2024-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from eb75201a4e03 to 0f69b790c7a4 (1 revision) 2024-02-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b54ff9b1d5ed to 16b5225bad88 (644 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: robertphillips@google.com Change-Id: Id19b5d080596973db6bc4b99e4b6b9e697cd8292 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819217 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Roll Skia from aa28c3a30a98 to d5ca52bc7739 (4 revisions)android-autoroll
https://skia.googlesource.com/skia.git/+log/aa28c3a30a98..d5ca52bc7739 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 34f900647879 to 73efb9ea35f6 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dd4b27ecbb53 to 34f900647879 (9 revisions) 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0f69b790c7a4 to bbe6452b420c (1 revision) 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dd6c2371c85d to cc25d8806a33 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/android-master-autoroll Please CC djsollen@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/186777432 Change-Id: I334e5652c99fe52f82cc0f80acaaa6a7334cff72
2024-02-27Roll SK Tool from 34f900647879 to 73efb9ea35f6skia-autoroll
https://skia.googlesource.com/buildbot.git/+log/34f900647879..73efb9ea35f6 2024-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from dd4b27ecbb53 to 34f900647879 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/sk-tool-skia Please CC rmistry@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: rmistry@google.com Change-Id: Iac9c8dd9affb52235ae7ed05e0e61fe86bb8b3c4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819218 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Roll Skia Infra from dd4b27ecbb53 to 34f900647879 (9 revisions)skia-autoroll
https://skia.googlesource.com/buildbot.git/+log/dd4b27ecbb53..34f900647879 2024-02-26 haowoo@google.com Refactor run_benchmark params. 2024-02-26 sunxiaodi@google.com [pinpoint] update android perf browser from android-trichrome-bundle 2024-02-26 jeffyoon@google.com [bisection] implement benchmark interface 2024-02-26 jeffyoon@google.com [pinpoint] Refactor swarming logic to backends/ 2024-02-26 jeffyoon@google.com [bisection] add android-pixel2_webview-perf to isolate_targets 2024-02-26 bwils@google.com Improve Skottie viewer dev instructions 2024-02-26 borenet@google.com [autoroll] Run "git gc" on every sync 2024-02-26 borenet@google.com [autoroll] Log CIPD tags when we fail to find instances 2024-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 88ef1b147e5e to dd4b27ecbb53 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC rmistry@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: rmistry@google.com Change-Id: I05117edab0b477844934409fb0d5c7ec803c4efc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818604 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Roll SwiftShader from 0f69b790c7a4 to bbe6452b420c (1 revision)skia-autoroll
https://swiftshader.googlesource.com/SwiftShader.git/+log/0f69b790c7a4..bbe6452b420c 2024-02-26 natsu@google.com Support ycbcr conversion linear filtering If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-skia-autoroll Please CC bsalomon@google.com,robertphillips@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader Bug: None Tbr: robertphillips@google.com Change-Id: I34af4897e4897f62def644112cf5ee6b1d31c9f5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819197 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Roll vulkan-deps from dd6c2371c85d to cc25d8806a33 (7 revisions)skia-autoroll
https://chromium.googlesource.com/vulkan-deps.git/+log/dd6c2371c85d..cc25d8806a33 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/c3a9ffd74f8b27434d220f2e48a98ac6cd72d178..99a3ad32ffbf35797ca079537940bb5c870ebaaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC robertphillips@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: robertphillips@google.com Change-Id: Ie2abda65554e853db206bec22d55a6f6e167f75f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/819117 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2024-02-27Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions)android-autoroll
https://skia.googlesource.com/skia.git/+log/ba3ed5998af3..aa28c3a30a98 2024-02-26 brianosman@google.com Handle recursion limit gracefully in the stroker 2024-02-26 johnstiles@google.com Revert "[skif] Add transparent padding to source saveLayers" 2024-02-26 johnstiles@google.com Use nmad primitive in inverse and transcendental functions. 2024-02-26 herb@google.com Reland "Implement ARM only unpremul using SIMD" 2024-02-26 johnstiles@google.com Add Raster Pipeline fused negative multiply-add primitive. 2024-02-26 michaelludwig@google.com [skif] Add transparent padding to source saveLayers 2024-02-26 kjlubick@google.com Try adding a gn clean before building fontations 2024-02-26 herb@google.com Revert "Implement ARM only unpremul using SIMD" 2024-02-26 herb@google.com Implement ARM only unpremul using SIMD 2024-02-26 jvanverth@google.com [graphite] Enable SmallPathAtlas. 2024-02-26 michaelludwig@google.com Update legacy LCD ARGB32 blitter to match RP for transparent pixels 2024-02-26 johnstiles@google.com Add Perlin Noise Raster Pipeline implementation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/android-master-autoroll Please CC djsollen@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/294378744 Bug: b/323034773 Bug: b/323886195 Bug: b/40043963 Bug: b/40045243 Bug: b/40810065 Bug: b/41422450 Bug: b/186777432 Change-Id: Ic4de8e42da9a17986288debb77bfdc224feaf1a8
2024-02-26Handle recursion limit gracefully in the strokerBrian Osman
Before: If we ever reached the recursion limit (ie, no forward progress subdividing a curve), we would give up on that branch of work. This resulted in the recursion unwinding completely, causing the algorithm to stop prematurely. Then, we'd simply close the resulting path, part-way through stroking. The end result was that the stroked path would have a big fill cutting across the middle (from wherever we gave up, back to the path's first point). Now: When we reach the recursion limit, we just emit a line, and stop trying to subdivide. We're almost certainly in a spot where no one can tell (the failure is a degenerate numerical issue anyway). This lets us continue stroking, and produce plausible (probably correct within human tolerance) results. The actual resulting paths are going to be extremely large and slow to draw (hitting this limit means we tried to subdivide ~30 times), but that's much better than before. Interestingly, we had bug reports for this that involved each of the relevant curve types (quad, cubic, and conic), so we have test GMs for all three now. Each one drew wrong before the relevant fix, and now looks correct. Bug: b/40043963 Bug: b/41422450 Bug: b/40810065 Change-Id: I97b0863e33ece5ba2a82d6dcd4452a91ee396adc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/817621 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2024-02-26Revert "[skif] Add transparent padding to source saveLayers"John Stiles
This reverts commit 74661f1ccf74f7d1d243ccfff505f5355774b998. Reason for revert: breaking Flutter roll Original change's description: > [skif] Add transparent padding to source saveLayers > > Bug: b/323886195 > Change-Id: I29bcdf6832ebe53f816764438b3d0017909bdafd > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/813016 > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> Bug: b/323886195 Change-Id: Iae3e5bb6fdf4d8fb8bf710384c9152f77da3275d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818976 Auto-Submit: John Stiles <johnstiles@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2024-02-26Use nmad primitive in inverse and transcendental functions.John Stiles
This should generate smaller (and faster!) code by getting rid of explicit neg instructions. This is particularly effective on ARM. On Intel it looks like the compiler was already able to replace `vfmadd231ps` with `vfmsub231ps` in some places, which would capture a very similar code-size savings, but ARM does not seem to attempt anything similar. Change-Id: I35253de4b159ae991ade610b28727d9ee6f21a1f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818516 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2024-02-26Reland "Implement ARM only unpremul using SIMD"Herb Derby
This is a reland of commit 49f18efdfa733e96e4f57122a239834fcb2c91d7 The benchmark now reports 65.2µs. Bug: b/323034773 Original change's description: > Implement ARM only unpremul using SIMD > > This drops the benchmark time by another 15%: 73.6µs -> 62.1µs. It > looks like the divide instruction is the limiting factor for the > portable and SIMD implementations. > > Bug: b/323034773 > Change-Id: I0db8d2d957dc0cb791c1ae3253e4a274f1bd6f17 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/814416 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Herb Derby <herb@google.com> Bug: b/323034773 Change-Id: I69fd2e7127f3bf6f9540a46420ac4b6c73409586 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818617 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2024-02-26Add Raster Pipeline fused negative multiply-add primitive.John Stiles
All of our RP platforms which support fma today also support fused negative multiply-add. FMA calculates `a*b + c`; FNMA calculates `-a*b + c`. (Another way to frame it is `a + b*c` versus `a - b*c`, but the multiplication occurs first, so it's mentally simpler to place it on the left-hand side, at least for me.) This can occasionally produce better code, and the compiler doesn't seem to be smart enough to emit this op on its own, so it's worth having the primitive in our toolbox. (Unfortunately, ARM doesn't appear to have an `a*b - c` primitive; I was looking for that, but this is the closest I could get.) I've updated inverse_mat2 to use the new primitive in order to get some test coverage. This will cause the `runtime_intrinsics_matrix` slide to use `nmad` while rendering the 2x2 matrix inverse tile. Change-Id: I5d5ed0116235569d2b47db44245eeba969932fe1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818416 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2024-02-26[skif] Add transparent padding to source saveLayersMichael Ludwig
Bug: b/323886195 Change-Id: I29bcdf6832ebe53f816764438b3d0017909bdafd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/813016 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2024-02-26Try adding a gn clean before building fontationsK Lubick
My hypothesis is that GN doesn't know it needs to rebuild some of the Rust libraries when something (maybe the rust version?) changed, so we'll just tell it to do a "clean" before building to encourage it to re-run the Bazel commands (which *do* know they should be re-built). Change-Id: I0d2b5344e59f50d9e3c7c4c2bed6d9e00c5245af Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818536 Reviewed-by: Brian Osman <brianosman@google.com>
2024-02-26Revert "Implement ARM only unpremul using SIMD"Herb Derby
This reverts commit 49f18efdfa733e96e4f57122a239834fcb2c91d7. Reason for revert: Bad round tripping Original change's description: > Implement ARM only unpremul using SIMD > > This drops the benchmark time by another 15%: 73.6µs -> 62.1µs. It > looks like the divide instruction is the limiting factor for the > portable and SIMD implementations. > > Bug: b/323034773 > Change-Id: I0db8d2d957dc0cb791c1ae3253e4a274f1bd6f17 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/814416 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Herb Derby <herb@google.com> Bug: b/323034773 Change-Id: I8d5cdaf1d6663e595ccbd005b1efff851229665a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/818616 Commit-Queue: Herb Derby <herb@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2024-02-26Implement ARM only unpremul using SIMDHerb Derby
This drops the benchmark time by another 15%: 73.6µs -> 62.1µs. It looks like the divide instruction is the limiting factor for the portable and SIMD implementations. Bug: b/323034773 Change-Id: I0db8d2d957dc0cb791c1ae3253e4a274f1bd6f17 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/814416 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Herb Derby <herb@google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 07:26:15 +0000