Test: New GMs should be nicely named

Motivation:

    An issue came up a while back with SkQP where some the JUnit testing
    framework dislikes test names that aren't valid Java identifiers.  I am
    currently replacing invalid characters with underscores before giving
    them to JUnit, but that leads to some confusion when trying to grep for
    the name of a failing test.

    I propose that going forward, all *new* Skia unit tests and GM names be
    in the form [A-Za-z][A-Za-z0-9_]* to prevent this sort of confusion.  We
    won't change 63 existing "bad" tests names.

This Cl encorces that rule with an assertion in DM.

Change-Id: Icedce023cd3127d499fbcdcaea485f1ec9e9196b
Reviewed-on: https://skia-review.googlesource.com/145365
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>

1 files changed, 1 insertions, 0 deletions

diff --git a/BUILD.gn b/BUILD.gn
index 535eed2f0e..b0e4a94f72 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1601,6 +1601,7 @@ if (skia_enable_tools) {
         "dm/DMGpuTestProcs.cpp",
         "dm/DMJsonWriter.cpp",
         "dm/DMSrcSink.cpp",
+        "dm/ValidateGMNames.cpp",
       ]
       include_dirs = [ "tests" ]
       deps = [