diff options
author | Herb Derby <herb@google.com> | 2018-11-08 16:40:26 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-11-09 20:01:42 +0000 |
commit | c34150079a0aa7b4ef0f79611c536ae336a65089 (patch) | |
tree | dca55628ace300493e1eec840f2b204555ede3c9 /src/gpu/text/GrTextBlob.cpp | |
parent | 106296323223b6ac9980862ae6e9ce039bbd1534 (diff) | |
download | skqp-c34150079a0aa7b4ef0f79611c536ae336a65089.tar.gz |
Reland "Move remove ptr args to MakeRecAndEffects"
This is a reland of b07aba42145e29e0e995b373844c59846058a9ba
Original change's description:
> Move remove ptr args to MakeRecAndEffects
>
> Move this conversion out through the transitive closure of calls. As you
> move up the stack, everything becomes refs instread of pointers.
>
> Reorder args of MakeRecAndEffects and setupCache to match the majority of other
> calls.
>
> Change-Id: I72baf457cd9140f76ee5f7122493284c4be5bcd0
> Reviewed-on: https://skia-review.googlesource.com/c/169765
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Herb Derby <herb@google.com>
Change-Id: I2ff7f218ecc7b18ae6a2b293cecdb059eea77562
Reviewed-on: https://skia-review.googlesource.com/c/170222
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Diffstat (limited to 'src/gpu/text/GrTextBlob.cpp')
-rw-r--r-- | src/gpu/text/GrTextBlob.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/gpu/text/GrTextBlob.cpp b/src/gpu/text/GrTextBlob.cpp index cc686f558a..e0351241d9 100644 --- a/src/gpu/text/GrTextBlob.cpp +++ b/src/gpu/text/GrTextBlob.cpp @@ -59,10 +59,10 @@ sk_sp<GrTextBlob> GrTextBlob::Make(int glyphCount, int runCount) { } SkExclusiveStrikePtr GrTextBlob::setupCache(int runIndex, - const SkSurfaceProps& props, - SkScalerContextFlags scalerContextFlags, - const SkPaint& skPaint, - const SkMatrix* viewMatrix) { + const SkPaint& skPaint, + const SkSurfaceProps& props, + SkScalerContextFlags scalerContextFlags, + const SkMatrix& viewMatrix) { GrTextBlob::Run* run = &fRuns[runIndex]; // if we have an override descriptor for the run, then we should use that @@ -70,7 +70,7 @@ SkExclusiveStrikePtr GrTextBlob::setupCache(int runIndex, &run->fDescriptor; SkScalerContextEffects effects; SkScalerContext::CreateDescriptorAndEffectsUsingPaint( - skPaint, &props, scalerContextFlags, viewMatrix, desc, &effects); + skPaint, props, scalerContextFlags, viewMatrix, desc, &effects); run->fTypeface = SkPaintPriv::RefTypefaceOrDefault(skPaint); run->fPathEffect = sk_ref_sp(effects.fPathEffect); run->fMaskFilter = sk_ref_sp(effects.fMaskFilter); |