diff options
| author | Andreas Gampe <agampe@google.com> | 2018-01-23 11:20:52 -0800 |
|---|---|---|
| committer | Ben Gruver <jesusfreke@jesusfreke.com> | 2018-01-23 11:56:02 -0800 |
| commit | 681222d39137afb0bcfa88e17fc3a5fbdfe7a4c3 (patch) | |
| tree | 72879550b5f8c1c5bd8a2b455626735cf1e0a81d | |
| parent | 948c0205b8140ea1d4a7755c087d9c898379bff9 (diff) | |
| download | smali-681222d39137afb0bcfa88e17fc3a5fbdfe7a4c3.tar.gz | |
Fix NaN comparison
Use Float.isNaN/Double.isNaN to correctly detect NaN.
Detected by errorprone.
| -rw-r--r-- | baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java b/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java index d58b2b68..b69995df 100644 --- a/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java +++ b/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java @@ -501,7 +501,7 @@ public class InstructionMethodItem<T extends Instruction> extends MethodItem { writer.write("Float.POSITIVE_INFINITY"); else if (fval == Float.NEGATIVE_INFINITY) writer.write("Float.NEGATIVE_INFINITY"); - else if (fval == Float.NaN) + else if (Float.isNaN(fval)) writer.write("Float.NaN"); else if (fval == Float.MAX_VALUE) writer.write("Float.MAX_VALUE"); @@ -528,7 +528,7 @@ public class InstructionMethodItem<T extends Instruction> extends MethodItem { writer.write("Double.POSITIVE_INFINITY"); else if (dval == Double.NEGATIVE_INFINITY) writer.write("Double.NEGATIVE_INFINITY"); - else if (dval == Double.NaN) + else if (Double.isNaN(dval)) writer.write("Double.NaN"); else if (dval == Double.MAX_VALUE) writer.write("Double.MAX_VALUE"); |