From 681222d39137afb0bcfa88e17fc3a5fbdfe7a4c3 Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Tue, 23 Jan 2018 11:20:52 -0800 Subject: Fix NaN comparison Use Float.isNaN/Double.isNaN to correctly detect NaN. Detected by errorprone. --- .../java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'baksmali') diff --git a/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java b/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java index d58b2b68..b69995df 100644 --- a/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java +++ b/baksmali/src/main/java/org/jf/baksmali/Adaptors/Format/InstructionMethodItem.java @@ -501,7 +501,7 @@ public class InstructionMethodItem extends MethodItem { writer.write("Float.POSITIVE_INFINITY"); else if (fval == Float.NEGATIVE_INFINITY) writer.write("Float.NEGATIVE_INFINITY"); - else if (fval == Float.NaN) + else if (Float.isNaN(fval)) writer.write("Float.NaN"); else if (fval == Float.MAX_VALUE) writer.write("Float.MAX_VALUE"); @@ -528,7 +528,7 @@ public class InstructionMethodItem extends MethodItem { writer.write("Double.POSITIVE_INFINITY"); else if (dval == Double.NEGATIVE_INFINITY) writer.write("Double.NEGATIVE_INFINITY"); - else if (dval == Double.NaN) + else if (Double.isNaN(dval)) writer.write("Double.NaN"); else if (dval == Double.MAX_VALUE) writer.write("Double.MAX_VALUE"); -- cgit v1.2.3