1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
|
// SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later
package parser2v2
import (
"testing"
"github.com/spdx/tools-golang/spdx"
)
// ===== Parser other license section state change tests =====
func TestParser2_2OLStartsNewOtherLicenseAfterParsingLicenseIDTag(t *testing.T) {
// create the first other license
olid1 := "LicenseRef-Lic11"
olname1 := "License 11"
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &spdx.OtherLicense2_2{
LicenseIdentifier: olid1,
LicenseName: olname1,
},
}
olic1 := parser.otherLic
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
// the Document's OtherLicenses should have this one only
if parser.doc.OtherLicenses[0] != olic1 {
t.Errorf("Expected other license %v in OtherLicenses[0], got %v", olic1, parser.doc.OtherLicenses[0])
}
if parser.doc.OtherLicenses[0].LicenseName != olname1 {
t.Errorf("expected other license name %s in OtherLicenses[0], got %s", olname1, parser.doc.OtherLicenses[0].LicenseName)
}
// now add a new other license
olid2 := "LicenseRef-22"
olname2 := "License 22"
err := parser.parsePair2_2("LicenseID", olid2)
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should be correct
if parser.st != psOtherLicense2_2 {
t.Errorf("expected state to be %v, got %v", psOtherLicense2_2, parser.st)
}
// and an other license should be created
if parser.otherLic == nil {
t.Fatalf("parser didn't create new other license")
}
// also parse the new license's name
err = parser.parsePair2_2("LicenseName", olname2)
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should still be correct
if parser.st != psOtherLicense2_2 {
t.Errorf("expected state to be %v, got %v", psOtherLicense2_2, parser.st)
}
// and the other license name should be as expected
if parser.otherLic.LicenseName != olname2 {
t.Errorf("expected other license name %s, got %s", olname2, parser.otherLic.LicenseName)
}
// and the Document's Other Licenses should be of size 2 and have these two
if len(parser.doc.OtherLicenses) != 2 {
t.Fatalf("Expected OtherLicenses to have len 2, got %d", len(parser.doc.OtherLicenses))
}
if parser.doc.OtherLicenses[0] != olic1 {
t.Errorf("Expected other license %v in OtherLicenses[0], got %v", olic1, parser.doc.OtherLicenses[0])
}
if parser.doc.OtherLicenses[0].LicenseIdentifier != olid1 {
t.Errorf("expected other license ID %s in OtherLicenses[0], got %s", olid1, parser.doc.OtherLicenses[0].LicenseIdentifier)
}
if parser.doc.OtherLicenses[0].LicenseName != olname1 {
t.Errorf("expected other license name %s in OtherLicenses[0], got %s", olname1, parser.doc.OtherLicenses[0].LicenseName)
}
if parser.doc.OtherLicenses[1] != parser.otherLic {
t.Errorf("Expected other license %v in OtherLicenses[1], got %v", parser.otherLic, parser.doc.OtherLicenses[1])
}
if parser.doc.OtherLicenses[1].LicenseIdentifier != olid2 {
t.Errorf("expected other license ID %s in OtherLicenses[1], got %s", olid2, parser.doc.OtherLicenses[1].LicenseIdentifier)
}
if parser.doc.OtherLicenses[1].LicenseName != olname2 {
t.Errorf("expected other license name %s in OtherLicenses[1], got %s", olname2, parser.doc.OtherLicenses[1].LicenseName)
}
}
func TestParser2_2OLMovesToReviewAfterParsingReviewerTag(t *testing.T) {
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
}
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
err := parser.parsePair2_2("Reviewer", "Person: John Doe")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psReview2_2 {
t.Errorf("expected state to be %v, got %v", psReview2_2, parser.st)
}
}
func TestParser2_2OtherLicenseStaysAfterParsingRelationshipTags(t *testing.T) {
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &spdx.OtherLicense2_2{
LicenseIdentifier: "LicenseRef-whatever",
LicenseName: "the whatever license",
},
}
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
err := parser.parsePair2_2("Relationship", "SPDXRef-blah CONTAINS SPDXRef-blah-else")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should remain unchanged
if parser.st != psOtherLicense2_2 {
t.Errorf("expected state to be %v, got %v", psOtherLicense2_2, parser.st)
}
// and the relationship should be in the Document's Relationships
if len(parser.doc.Relationships) != 1 {
t.Fatalf("expected doc.Relationships to have len 1, got %d", len(parser.doc.Relationships))
}
deID := parser.doc.Relationships[0].RefA
if deID.DocumentRefID != "" || deID.ElementRefID != "blah" {
t.Errorf("expected RefA to be %s, got %s", "blah", parser.doc.Relationships[0].RefA)
}
err = parser.parsePair2_2("RelationshipComment", "blah")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should still remain unchanged
if parser.st != psOtherLicense2_2 {
t.Errorf("expected state to be %v, got %v", psOtherLicense2_2, parser.st)
}
}
func TestParser2_2OtherLicenseStaysAfterParsingAnnotationTags(t *testing.T) {
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &spdx.OtherLicense2_2{
LicenseIdentifier: "LicenseRef-whatever",
LicenseName: "the whatever license",
},
}
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
err := parser.parsePair2_2("Annotator", "Person: John Doe ()")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psOtherLicense2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psOtherLicense2_2)
}
err = parser.parsePair2_2("AnnotationDate", "2018-09-15T00:36:00Z")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psOtherLicense2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psOtherLicense2_2)
}
err = parser.parsePair2_2("AnnotationType", "REVIEW")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psOtherLicense2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psOtherLicense2_2)
}
err = parser.parsePair2_2("SPDXREF", "SPDXRef-45")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psOtherLicense2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psOtherLicense2_2)
}
err = parser.parsePair2_2("AnnotationComment", "i guess i had something to say about this particular file")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psOtherLicense2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psOtherLicense2_2)
}
// and the annotation should be in the Document's Annotations
if len(parser.doc.Annotations) != 1 {
t.Fatalf("expected doc.Annotations to have len 1, got %d", len(parser.doc.Annotations))
}
if parser.doc.Annotations[0].Annotator != "John Doe ()" {
t.Errorf("expected Annotator to be %s, got %s", "John Doe ()", parser.doc.Annotations[0].Annotator)
}
}
func TestParser2_2OLFailsAfterParsingOtherSectionTags(t *testing.T) {
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &spdx.OtherLicense2_2{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
}
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
// can't go back to old sections
err := parser.parsePair2_2("SPDXVersion", "SPDX-2.2")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
err = parser.parsePair2_2("PackageName", "whatever")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
err = parser.parsePair2_2("FileName", "whatever")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
}
// ===== Other License data section tests =====
func TestParser2_2CanParseOtherLicenseTags(t *testing.T) {
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
}
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
// License Identifier
err := parser.parsePairFromOtherLicense2_2("LicenseID", "LicenseRef-Lic11")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.otherLic.LicenseIdentifier != "LicenseRef-Lic11" {
t.Errorf("got %v for LicenseID", parser.otherLic.LicenseIdentifier)
}
// Extracted Text
err = parser.parsePairFromOtherLicense2_2("ExtractedText", "You are permitted to do anything with the software, hooray!")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.otherLic.ExtractedText != "You are permitted to do anything with the software, hooray!" {
t.Errorf("got %v for ExtractedText", parser.otherLic.ExtractedText)
}
// License Name
err = parser.parsePairFromOtherLicense2_2("LicenseName", "License 11")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.otherLic.LicenseName != "License 11" {
t.Errorf("got %v for LicenseName", parser.otherLic.LicenseName)
}
// License Cross Reference
crossRefs := []string{
"https://example.com/1",
"https://example.com/2",
"https://example.com/3",
}
for _, cr := range crossRefs {
err = parser.parsePairFromOtherLicense2_2("LicenseCrossReference", cr)
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
}
for _, refWant := range crossRefs {
flagFound := false
for _, refCheck := range parser.otherLic.LicenseCrossReferences {
if refWant == refCheck {
flagFound = true
}
}
if flagFound == false {
t.Errorf("didn't find %s in LicenseCrossReferences", refWant)
}
}
if len(crossRefs) != len(parser.otherLic.LicenseCrossReferences) {
t.Errorf("expected %d types in LicenseCrossReferences, got %d", len(crossRefs),
len(parser.otherLic.LicenseCrossReferences))
}
// License Comment
err = parser.parsePairFromOtherLicense2_2("LicenseComment", "this is a comment")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.otherLic.LicenseComment != "this is a comment" {
t.Errorf("got %v for LicenseComment", parser.otherLic.LicenseComment)
}
}
func TestParser2_2OLUnknownTagFails(t *testing.T) {
parser := tvParser2_2{
doc: &spdx.Document2_2{Packages: map[spdx.ElementID]*spdx.Package2_2{}},
st: psOtherLicense2_2,
pkg: &spdx.Package2_2{PackageName: "test", PackageSPDXIdentifier: "test", Files: map[spdx.ElementID]*spdx.File2_2{}},
file: &spdx.File2_2{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
}
parser.doc.Packages["test"] = parser.pkg
parser.pkg.Files["f1"] = parser.file
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
err := parser.parsePairFromOtherLicense2_2("blah", "something")
if err == nil {
t.Errorf("expected error from parsing unknown tag")
}
}
|
