1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
|
// SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later
package parser2v2
import (
"testing"
"github.com/spdx/tools-golang/spdx/v2_2"
)
// ===== Parser review section state change tests =====
func TestParser2_2ReviewStartsNewReviewAfterParsingReviewerTag(t *testing.T) {
// create the first review
rev1 := "John Doe"
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{
Reviewer: rev1,
ReviewerType: "Person",
},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
r1 := parser.rev
// the Document's Reviews should have this one only
if len(parser.doc.Reviews) != 1 {
t.Errorf("Expected only one review, got %d", len(parser.doc.Reviews))
}
if parser.doc.Reviews[0] != r1 {
t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
}
if parser.doc.Reviews[0].Reviewer != rev1 {
t.Errorf("expected review name %s in Reviews[0], got %s", rev1, parser.doc.Reviews[0].Reviewer)
}
// now add a new review
rev2 := "Steve"
rp2 := "Person: Steve"
err := parser.parsePair2_2("Reviewer", rp2)
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should be correct
if parser.st != psReview2_2 {
t.Errorf("expected state to be %v, got %v", psReview2_2, parser.st)
}
// and a review should be created
if parser.rev == nil {
t.Fatalf("parser didn't create new review")
}
// and the reviewer's name should be as expected
if parser.rev.Reviewer != rev2 {
t.Errorf("expected reviewer name %s, got %s", rev2, parser.rev.Reviewer)
}
// and the Document's reviews should be of size 2 and have these two
if len(parser.doc.Reviews) != 2 {
t.Fatalf("Expected Reviews to have len 2, got %d", len(parser.doc.Reviews))
}
if parser.doc.Reviews[0] != r1 {
t.Errorf("Expected review %v in Reviews[0], got %v", r1, parser.doc.Reviews[0])
}
if parser.doc.Reviews[0].Reviewer != rev1 {
t.Errorf("expected reviewer name %s in Reviews[0], got %s", rev1, parser.doc.Reviews[0].Reviewer)
}
if parser.doc.Reviews[1] != parser.rev {
t.Errorf("Expected review %v in Reviews[1], got %v", parser.rev, parser.doc.Reviews[1])
}
if parser.doc.Reviews[1].Reviewer != rev2 {
t.Errorf("expected reviewer name %s in Reviews[1], got %s", rev2, parser.doc.Reviews[1].Reviewer)
}
}
func TestParser2_2ReviewStaysAfterParsingRelationshipTags(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{
Reviewer: "Jane Doe",
ReviewerType: "Person",
},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
err := parser.parsePair2_2("Relationship", "SPDXRef-blah CONTAINS SPDXRef-blah-else")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should remain unchanged
if parser.st != psReview2_2 {
t.Errorf("expected state to be %v, got %v", psReview2_2, parser.st)
}
// and the relationship should be in the Document's Relationships
if len(parser.doc.Relationships) != 1 {
t.Fatalf("expected doc.Relationships to have len 1, got %d", len(parser.doc.Relationships))
}
deID := parser.doc.Relationships[0].RefA
if deID.DocumentRefID != "" || deID.ElementRefID != "blah" {
t.Errorf("expected RefA to be %s, got %s", "blah", parser.doc.Relationships[0].RefA)
}
err = parser.parsePair2_2("RelationshipComment", "blah")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
// state should still remain unchanged
if parser.st != psReview2_2 {
t.Errorf("expected state to be %v, got %v", psReview2_2, parser.st)
}
}
func TestParser2_2ReviewStaysAfterParsingAnnotationTags(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{
Reviewer: "Jane Doe",
ReviewerType: "Person",
},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
err := parser.parsePair2_2("Annotator", "Person: John Doe ()")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psReview2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psReview2_2)
}
err = parser.parsePair2_2("AnnotationDate", "2018-09-15T00:36:00Z")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psReview2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psReview2_2)
}
err = parser.parsePair2_2("AnnotationType", "REVIEW")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psReview2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psReview2_2)
}
err = parser.parsePair2_2("SPDXREF", "SPDXRef-45")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psReview2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psReview2_2)
}
err = parser.parsePair2_2("AnnotationComment", "i guess i had something to say about this particular file")
if err != nil {
t.Errorf("got error when calling parsePair2_2: %v", err)
}
if parser.st != psReview2_2 {
t.Errorf("parser is in state %v, expected %v", parser.st, psReview2_2)
}
// and the annotation should be in the Document's Annotations
if len(parser.doc.Annotations) != 1 {
t.Fatalf("expected doc.Annotations to have len 1, got %d", len(parser.doc.Annotations))
}
if parser.doc.Annotations[0].Annotator.Annotator != "John Doe ()" {
t.Errorf("expected Annotator to be %s, got %s", "John Doe ()", parser.doc.Annotations[0].Annotator)
}
}
func TestParser2_2ReviewFailsAfterParsingOtherSectionTags(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
// can't go back to old sections
err := parser.parsePair2_2("SPDXVersion", "SPDX-2.2")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
err = parser.parsePair2_2("PackageName", "whatever")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
err = parser.parsePair2_2("FileName", "whatever")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
err = parser.parsePair2_2("LicenseID", "LicenseRef-Lic22")
if err == nil {
t.Errorf("expected error when calling parsePair2_2, got nil")
}
}
// ===== Review data section tests =====
func TestParser2_2CanParseReviewTags(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
// Reviewer (DEPRECATED)
// handled in subsequent subtests
// Review Date (DEPRECATED)
err := parser.parsePairFromReview2_2("ReviewDate", "2018-09-23T08:30:00Z")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.rev.ReviewDate != "2018-09-23T08:30:00Z" {
t.Errorf("got %v for ReviewDate", parser.rev.ReviewDate)
}
// Review Comment (DEPRECATED)
err = parser.parsePairFromReview2_2("ReviewComment", "this is a comment")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.rev.ReviewComment != "this is a comment" {
t.Errorf("got %v for ReviewComment", parser.rev.ReviewComment)
}
}
func TestParser2_2CanParseReviewerPersonTag(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
// Reviewer: Person
err := parser.parsePairFromReview2_2("Reviewer", "Person: John Doe")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.rev.Reviewer != "John Doe" {
t.Errorf("got %v for Reviewer", parser.rev.Reviewer)
}
if parser.rev.ReviewerType != "Person" {
t.Errorf("got %v for ReviewerType", parser.rev.ReviewerType)
}
}
func TestParser2_2CanParseReviewerOrganizationTag(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
// Reviewer: Organization
err := parser.parsePairFromReview2_2("Reviewer", "Organization: John Doe, Inc.")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.rev.Reviewer != "John Doe, Inc." {
t.Errorf("got %v for Reviewer", parser.rev.Reviewer)
}
if parser.rev.ReviewerType != "Organization" {
t.Errorf("got %v for ReviewerType", parser.rev.ReviewerType)
}
}
func TestParser2_2CanParseReviewerToolTag(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
// Reviewer: Tool
err := parser.parsePairFromReview2_2("Reviewer", "Tool: scannertool - 1.2.12")
if err != nil {
t.Errorf("expected nil error, got %v", err)
}
if parser.rev.Reviewer != "scannertool - 1.2.12" {
t.Errorf("got %v for Reviewer", parser.rev.Reviewer)
}
if parser.rev.ReviewerType != "Tool" {
t.Errorf("got %v for ReviewerType", parser.rev.ReviewerType)
}
}
func TestParser2_2FailsIfReviewerInvalidFormat(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
rev: &v2_2.Review{},
}
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
err := parser.parsePairFromReview2_2("Reviewer", "oops")
if err == nil {
t.Errorf("expected non-nil error, got nil")
}
}
func TestParser2_2FailsIfReviewerUnknownType(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
rev: &v2_2.Review{},
}
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
err := parser.parsePairFromReview2_2("Reviewer", "whoops: John Doe")
if err == nil {
t.Errorf("expected non-nil error, got nil")
}
}
func TestParser2_2ReviewUnknownTagFails(t *testing.T) {
parser := tvParser2_2{
doc: &v2_2.Document{Packages: []*v2_2.Package{}},
st: psReview2_2,
pkg: &v2_2.Package{PackageName: "test", PackageSPDXIdentifier: "test", Files: []*v2_2.File{}},
file: &v2_2.File{FileName: "f1.txt", FileSPDXIdentifier: "f1"},
otherLic: &v2_2.OtherLicense{
LicenseIdentifier: "LicenseRef-Lic11",
LicenseName: "License 11",
},
rev: &v2_2.Review{},
}
parser.doc.Packages = append(parser.doc.Packages, parser.pkg)
parser.pkg.Files = append(parser.pkg.Files, parser.file)
parser.doc.OtherLicenses = append(parser.doc.OtherLicenses, parser.otherLic)
parser.doc.Reviews = append(parser.doc.Reviews, parser.rev)
err := parser.parsePairFromReview2_2("blah", "something")
if err == nil {
t.Errorf("expected error from parsing unknown tag")
}
}
|
