From 82fc8c1ff39066eae0638c11e78613f0b2e2e612 Mon Sep 17 00:00:00 2001 From: alandonovan Date: Thu, 3 Jan 2019 16:16:33 -0500 Subject: starlark: remove unused parameters (#88) --- starlark/eval.go | 8 ++++---- starlark/interp.go | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'starlark') diff --git a/starlark/eval.go b/starlark/eval.go index 56d25f2..45587cf 100644 --- a/starlark/eval.go +++ b/starlark/eval.go @@ -401,7 +401,7 @@ func listExtend(x *List, y Iterable) { } // getAttr implements x.dot. -func getAttr(fr *Frame, x Value, name string) (Value, error) { +func getAttr(x Value, name string) (Value, error) { // field or method? if x, ok := x.(HasAttrs); ok { if v, err := x.Attr(name); v != nil || err != nil { @@ -413,7 +413,7 @@ func getAttr(fr *Frame, x Value, name string) (Value, error) { } // setField implements x.name = y. -func setField(fr *Frame, x Value, name string, y Value) error { +func setField(x Value, name string, y Value) error { if x, ok := x.(HasSetField); ok { err := x.SetField(name, y) return err @@ -422,7 +422,7 @@ func setField(fr *Frame, x Value, name string, y Value) error { } // getIndex implements x[y]. -func getIndex(fr *Frame, x, y Value) (Value, error) { +func getIndex(x, y Value) (Value, error) { switch x := x.(type) { case Mapping: // dict z, found, err := x.Get(y) @@ -453,7 +453,7 @@ func getIndex(fr *Frame, x, y Value) (Value, error) { } // setIndex implements x[y] = z. -func setIndex(fr *Frame, x, y, z Value) error { +func setIndex(x, y, z Value) error { switch x := x.(type) { case HasSetKey: if err := x.SetKey(y, z); err != nil { diff --git a/starlark/interp.go b/starlark/interp.go index 551cbf8..fe332e8 100644 --- a/starlark/interp.go +++ b/starlark/interp.go @@ -334,7 +334,7 @@ loop: y := stack[sp-2] x := stack[sp-3] sp -= 3 - err = setIndex(fr, x, y, z) + err = setIndex(x, y, z) if err != nil { break loop } @@ -343,7 +343,7 @@ loop: y := stack[sp-1] x := stack[sp-2] sp -= 2 - z, err2 := getIndex(fr, x, y) + z, err2 := getIndex(x, y) if err2 != nil { err = err2 break loop @@ -354,7 +354,7 @@ loop: case compile.ATTR: x := stack[sp-1] name := f.Prog.Names[arg] - y, err2 := getAttr(fr, x, name) + y, err2 := getAttr(x, name) if err2 != nil { err = err2 break loop @@ -366,7 +366,7 @@ loop: x := stack[sp-2] sp -= 2 name := f.Prog.Names[arg] - if err2 := setField(fr, x, name, y); err2 != nil { + if err2 := setField(x, name, y); err2 != nil { err = err2 break loop } -- cgit v1.2.3