aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCedric Beust <cedric@beust.com>2015-12-08 09:11:21 -0800
committerCedric Beust <cedric@beust.com>2015-12-08 09:11:21 -0800
commited0266b4d8ddcb78f03f74033609aa5e1d72940f (patch)
treed3984e9509cbc6926a85dc9508b38a27f0b81a7f
parent7f47f7ffdf78eedbf33ef264c795ba90543e283a (diff)
parent8ed18e3b37fa333a844f07e1e9c2caea8c33571b (diff)
downloadtestng-ed0266b4d8ddcb78f03f74033609aa5e1d72940f.tar.gz
Merge pull request #908 from juherr/NaN
Fix Double.NaN assertion
-rw-r--r--src/main/java/org/testng/Assert.java7
-rw-r--r--src/test/java/test/asserttests/AssertTest.java5
2 files changed, 11 insertions, 1 deletions
diff --git a/src/main/java/org/testng/Assert.java b/src/main/java/org/testng/Assert.java
index 6ffcbf12..fe37b4bd 100644
--- a/src/main/java/org/testng/Assert.java
+++ b/src/main/java/org/testng/Assert.java
@@ -217,7 +217,12 @@ public class Assert {
failNotEquals(actual, expected, message);
}
}
- else if(!(Math.abs(expected - actual) <= delta)) { // Because comparison with NaN always returns false
+ else if (Double.isNaN(expected)) {
+ if (!Double.isNaN(actual)) {
+ failNotEquals(actual, expected, message);
+ }
+ }
+ else if(!(Math.abs(expected - actual) <= delta)) {
failNotEquals(actual, expected, message);
}
}
diff --git a/src/test/java/test/asserttests/AssertTest.java b/src/test/java/test/asserttests/AssertTest.java
index 7a4abfdc..1191d6cc 100644
--- a/src/test/java/test/asserttests/AssertTest.java
+++ b/src/test/java/test/asserttests/AssertTest.java
@@ -148,4 +148,9 @@ public class AssertTest {
}
};
}
+
+ @Test
+ public void doubleNaNAssertion() {
+ Assert.assertEquals(Double.NaN, Double.NaN, 0.0);
+ }
}