diff options
| author | Thai Duong <thaidn@google.com> | 2017-10-23 13:25:20 -0700 |
|---|---|---|
| committer | Thai Duong <thaidn@google.com> | 2017-10-25 23:44:45 -0700 |
| commit | 34de6dd920e84319cc0a53e9ebd3993a7544ddcd (patch) | |
| tree | a0d63b1a1a61a602838cff2ee6e530459d8b4bd3 /cc/mac/mac_config_test.cc | |
| parent | 89146caa17ed985265972821107ceb030cc41c7e (diff) | |
| download | tink-34de6dd920e84319cc0a53e9ebd3993a7544ddcd.tar.gz | |
Replacing StringPiece with const std::string& when it makes sense.
This makes sense if the StringPiece is converted to std::string
with StringPiece.ToString() which does copy the string, thus should
be avoided.
This also makes the migration to absl::string_view easier. Somehow
one cannot pass a string_view to methods that take const std::string&
(it's possible to do that with StringPiece so I guess it's because
string_view does not provide an implicit conversion to const std::string&,
but I'm not sure).
Change-Id: Ic905a78752c63ac60f25d73ba7898f723e41d9df
ORIGINAL_AUTHOR=Thai Duong <thaidn@google.com>
GitOrigin-RevId: fbd1fb69494ac4b9b982804c86fcae1f2902aef7
Diffstat (limited to 'cc/mac/mac_config_test.cc')
| -rw-r--r-- | cc/mac/mac_config_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cc/mac/mac_config_test.cc b/cc/mac/mac_config_test.cc index 131c370c0..bb99a17c1 100644 --- a/cc/mac/mac_config_test.cc +++ b/cc/mac/mac_config_test.cc @@ -34,8 +34,8 @@ class DummyMacCatalogue : public Catalogue<Mac> { DummyMacCatalogue() {} crypto::tink::util::StatusOr<std::unique_ptr<KeyManager<Mac>>> - GetKeyManager(google::protobuf::StringPiece type_url, - google::protobuf::StringPiece primitive_name, + GetKeyManager(const std::string& type_url, + const std::string& primitive_name, uint32_t min_version) const override { return util::Status::UNKNOWN; } |