diff options
| author | Manoj Gupta <manojgupta@google.com> | 2020-12-17 11:49:41 -0800 |
|---|---|---|
| committer | Manoj Gupta <manojgupta@chromium.org> | 2020-12-29 19:19:31 +0000 |
| commit | 98b1224f79c959955838bf66c13dc3e01999dd72 (patch) | |
| tree | 36ee6a985bf3a5dbd3e9d9a10668ade69ab86b0a | |
| parent | 63b249a4ba47b154fa2c3c94029e52f2874e395c (diff) | |
| download | toolchain-utils-98b1224f79c959955838bf66c13dc3e01999dd72.tar.gz | |
compiler_wrapper: remove "-pass-exit-codes" in wrapper
Handling(ignoring) of "-pass-exit-codes" flag is no longer
needed in compiler wrapper.
BUG=chromium:979911
TEST=CL:2597389 passed CQ/SDK tests
Change-Id: I0114b745eed6d5dbcba10e2ecfb13d1882df32bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2597141
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
6 files changed, 2 insertions, 8 deletions
diff --git a/compiler_wrapper/clang_flags.go b/compiler_wrapper/clang_flags.go index 9eb951de..53d70d50 100644 --- a/compiler_wrapper/clang_flags.go +++ b/compiler_wrapper/clang_flags.go @@ -46,9 +46,7 @@ func processClangFlags(builder *commandBuilder) error { // // Use of -Qunused-arguments allows this set to be small, just those // that clang still warns about. - unsupported := map[string]bool{ - "-pass-exit-codes": true, - } + unsupported := make(map[string]bool) unsupportedPrefixes := []string{"-Wstrict-aliasing=", "-finline-limit="} diff --git a/compiler_wrapper/clang_flags_test.go b/compiler_wrapper/clang_flags_test.go index a4145c22..edeb15a4 100644 --- a/compiler_wrapper/clang_flags_test.go +++ b/compiler_wrapper/clang_flags_test.go @@ -211,7 +211,6 @@ func TestFilterUnsupportedClangFlags(t *testing.T) { flag string expectedCount int }{ - {clangX86_64, "-pass-exit-codes", 0}, {clangX86_64, "-Wstrict-aliasing=xyz", 0}, {clangX86_64, "-finline-limit=xyz", 0}, {"./armv7a-cros-linux-gnu-clang", "-ftrapv", 0}, diff --git a/compiler_wrapper/cros_hardened_config_test.go b/compiler_wrapper/cros_hardened_config_test.go index b459f1e2..6d96b182 100644 --- a/compiler_wrapper/cros_hardened_config_test.go +++ b/compiler_wrapper/cros_hardened_config_test.go @@ -517,7 +517,7 @@ func createClangArgsGoldenInputs() goldenFile { Name: "clang_specific_args.json", Records: []goldenRecord{ { - WrapperCmd: newGoldenCmd(clangX86_64, "-mno-movbe", "-pass-exit-codes", "-Wclobbered", "-Wno-psabi", "-Wlogical-op", + WrapperCmd: newGoldenCmd(clangX86_64, "-mno-movbe", "-Wclobbered", "-Wno-psabi", "-Wlogical-op", "-Wmissing-parameter-type", "-Wold-style-declaration", "-Woverride-init", "-Wunsafe-loop-optimizations", "-Wstrict-aliasing=abc", "-finline-limit=abc", mainCc), Cmds: okResults, diff --git a/compiler_wrapper/testdata/cros_clang_host_golden/clang_specific_args.json b/compiler_wrapper/testdata/cros_clang_host_golden/clang_specific_args.json index bddb110e..432c876e 100644 --- a/compiler_wrapper/testdata/cros_clang_host_golden/clang_specific_args.json +++ b/compiler_wrapper/testdata/cros_clang_host_golden/clang_specific_args.json @@ -6,7 +6,6 @@ "path": "./x86_64-cros-linux-gnu-clang", "args": [ "-mno-movbe", - "-pass-exit-codes", "-Wclobbered", "-Wno-psabi", "-Wlogical-op", diff --git a/compiler_wrapper/testdata/cros_hardened_golden/clang_specific_args.json b/compiler_wrapper/testdata/cros_hardened_golden/clang_specific_args.json index 0d4aaf92..48ee7999 100644 --- a/compiler_wrapper/testdata/cros_hardened_golden/clang_specific_args.json +++ b/compiler_wrapper/testdata/cros_hardened_golden/clang_specific_args.json @@ -6,7 +6,6 @@ "path": "./x86_64-cros-linux-gnu-clang", "args": [ "-mno-movbe", - "-pass-exit-codes", "-Wclobbered", "-Wno-psabi", "-Wlogical-op", diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clang_specific_args.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clang_specific_args.json index aafdaba0..7b56d582 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clang_specific_args.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clang_specific_args.json @@ -6,7 +6,6 @@ "path": "./x86_64-cros-linux-gnu-clang", "args": [ "-mno-movbe", - "-pass-exit-codes", "-Wclobbered", "-Wno-psabi", "-Wlogical-op", |