diff options
author | Caroline Tice <cmtice@google.com> | 2018-12-18 15:54:49 -0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-12-20 13:49:40 -0800 |
commit | 219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5 (patch) | |
tree | 37a78e03aa708d8b4a2c7f36efb7c0ddf03fd164 | |
parent | ef4b788bb5a1ba47881c73901228a07f5430ad4c (diff) | |
download | toolchain-utils-219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5.tar.gz |
toolchain-utils: Add loading.desktop@@typical to nightly tests.
page_cycler_v2.typical_25 is deprecated (and flaky!). The
recommended replacement is loading.desktop@@typical. This CL updates
our nightly performance test infrastructure to handle
loading.desktop@@typical.
BUG=chromium:916340
TEST=Tested with nightly run on chrotomation2.
Change-Id: I6366b3a8e6a2926ad759a209cfded890e3109810
Reviewed-on: https://chromium-review.googlesource.com/1382826
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
-rwxr-xr-x | buildbot_test_toolchains.py | 9 | ||||
-rw-r--r-- | crosperf/benchmark.py | 1 | ||||
-rw-r--r-- | crosperf/default-telemetry-results.json | 4 | ||||
-rw-r--r-- | crosperf/results_organizer.py | 2 |
4 files changed, 11 insertions, 5 deletions
diff --git a/buildbot_test_toolchains.py b/buildbot_test_toolchains.py index bf3a8dea..73decf25 100755 --- a/buildbot_test_toolchains.py +++ b/buildbot_test_toolchains.py @@ -92,7 +92,7 @@ class ToolchainComparator(object): Args: trybot_image: artifact name such as - 'daisy-release-tryjob/R40-6394.0.0-b1389' + 'daisy-release-tryjob/R40-6394.0.0-b1389' Returns: Latest official image name, e.g. 'daisy-release/R57-9089.0.0'. @@ -117,7 +117,7 @@ class ToolchainComparator(object): Args: trybot_image: artifact name such as - 'daisy-release-tryjob/R40-6394.0.0-b1389' + 'daisy-release-tryjob/R40-6394.0.0-b1389' Returns: Corresponding chrome PFQ image name, e.g. @@ -162,9 +162,10 @@ class ToolchainComparator(object): run_local: False } - benchmark: page_cycler_v2.typical_25 { + benchmark: loading.desktop { suite: telemetry_Crosperf - iterations: 0 + test_args: --story-tag-filter=typical + iterations: 3 run_local: False retries: 0 } diff --git a/crosperf/benchmark.py b/crosperf/benchmark.py index 967cfff4..6869bacb 100644 --- a/crosperf/benchmark.py +++ b/crosperf/benchmark.py @@ -17,6 +17,7 @@ _estimated_stddev = { 'dromaeo.domcoremodify': 0.011, 'graphics_WebGLAquarium': 0.008, 'page_cycler_v2.typical_25': 0.021, + 'loading.desktop': 0.021, # Copied from page_cycler initially } diff --git a/crosperf/default-telemetry-results.json b/crosperf/default-telemetry-results.json index 240664b5..a25af7ea 100644 --- a/crosperf/default-telemetry-results.json +++ b/crosperf/default-telemetry-results.json @@ -16,6 +16,10 @@ "percentage_smooth__percentage_smooth", "percentage_smooth__summary" ], + "loading.desktop@@typical": [ + "cold@@timeToFirstContentfulPaint_avg__summary", + "warm@@timeToFirstContentfulPaint_avg__summary" + ], "page_cycler_v2.intl_es_fr_pt-BR": [ "cold_times__page_load_time", "warm_times__page_load_time", diff --git a/crosperf/results_organizer.py b/crosperf/results_organizer.py index bda0cc17..c39119bb 100644 --- a/crosperf/results_organizer.py +++ b/crosperf/results_organizer.py @@ -182,7 +182,7 @@ def OrganizeResults(benchmark_runs, labels, benchmarks=None, json_report=False): show_all_results = json_report or benchmark.show_all_results if not show_all_results: - summary_list = summary_file.get(benchmark.test_name) + summary_list = summary_file.get(benchmark.name) if summary_list: summary_list.append('retval') else: |