aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Burgess IV <gbiv@google.com>2022-01-18 13:22:09 -0800
committerCommit Bot <commit-bot@chromium.org>2022-01-18 23:52:18 +0000
commit72d98e4ca9ac0147b1025836214c88696919c532 (patch)
tree0e675aea4be828b6bb2f8205c3d1e7df5dd75e7c
parent96968ca5d35291869c6801b7e96f89b3c7d49249 (diff)
downloadtoolchain-utils-72d98e4ca9ac0147b1025836214c88696919c532.tar.gz
rust_watch: use better titles for bugs
These titles are more consistent with bugs filed for Rust upgrades in the past. BUG=b:215209865 TEST=Unittests Change-Id: I1673bda6a033f70a276f6cfe8af17709db985feb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3399867 Tested-by: George Burgess <gbiv@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by: Michael Benfield <mbenfield@google.com> Commit-Queue: George Burgess <gbiv@chromium.org>
-rwxr-xr-xrust_tools/rust_watch.py2
-rwxr-xr-xrust_tools/rust_watch_test.py6
2 files changed, 4 insertions, 4 deletions
diff --git a/rust_tools/rust_watch.py b/rust_tools/rust_watch.py
index db6ae71b..c347d2c6 100755
--- a/rust_tools/rust_watch.py
+++ b/rust_tools/rust_watch.py
@@ -241,7 +241,7 @@ def maybe_compose_bug(
if newest_release == old_state.last_seen_release:
return None
- title = f'New rustc release detected: v{newest_release}'
+ title = f'[Rust] Update to {newest_release}'
body = ('A new release has been detected; we should probably roll to it. '
"Please see go/crostc-rust-rotation for who's turn it is.")
return title, body
diff --git a/rust_tools/rust_watch_test.py b/rust_tools/rust_watch_test.py
index 30bacbb9..583a9125 100755
--- a/rust_tools/rust_watch_test.py
+++ b/rust_tools/rust_watch_test.py
@@ -129,7 +129,7 @@ class Test(unittest.TestCase):
),
newest_release=rust_watch.RustReleaseVersion(1, 0, 1),
)
- self.assertEqual(title, 'New rustc release detected: v1.0.1')
+ self.assertEqual(title, '[Rust] Update to 1.0.1')
self.assertTrue(body.startswith('A new release has been detected;'))
title, body = rust_watch.maybe_compose_bug(
@@ -139,7 +139,7 @@ class Test(unittest.TestCase):
),
newest_release=rust_watch.RustReleaseVersion(1, 1, 0),
)
- self.assertEqual(title, 'New rustc release detected: v1.1.0')
+ self.assertEqual(title, '[Rust] Update to 1.1.0')
self.assertTrue(body.startswith('A new release has been detected;'))
title, body = rust_watch.maybe_compose_bug(
@@ -149,7 +149,7 @@ class Test(unittest.TestCase):
),
newest_release=rust_watch.RustReleaseVersion(2, 0, 0),
)
- self.assertEqual(title, 'New rustc release detected: v2.0.0')
+ self.assertEqual(title, '[Rust] Update to 2.0.0')
self.assertTrue(body.startswith('A new release has been detected;'))
def test_compose_bug_does_nothing_when_no_new_updates_exist(self):