diff options
| author | Denis Nikitin <denik@google.com> | 2022-09-01 14:41:40 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-02 19:25:17 +0000 |
| commit | 7d2a6951f9361849982537ed1ea0825f3588f157 (patch) | |
| tree | 4151fc4ba488b52d1082d7019c5f79c033441d29 | |
| parent | 0665748ca334615e7f41978c36b8fba7817ed2c7 (diff) | |
| download | toolchain-utils-7d2a6951f9361849982537ed1ea0825f3588f157.tar.gz | |
toolchain-utils: Fix lint errors
Move the variable with comments away from import. It causes a conflict
between yapf and lint/isort.
BUG=b:244644217
TEST=repo hooks pass
Change-Id: I50942a6355d30e3d39e9e60fc26e8eba687eba05
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3869850
Tested-by: Denis Nikitin <denik@chromium.org>
Auto-Submit: Denis Nikitin <denik@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
| -rwxr-xr-x | buildbot_test_toolchains.py | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/buildbot_test_toolchains.py b/buildbot_test_toolchains.py index 3594fddb..4caa906e 100755 --- a/buildbot_test_toolchains.py +++ b/buildbot_test_toolchains.py @@ -26,13 +26,10 @@ import shutil import sys import time +from cros_utils import buildbot_utils from cros_utils import command_executer from cros_utils import logger -from cros_utils import buildbot_utils - -# CL that uses LLVM-Next to build the images (includes chrome). -USE_LLVM_NEXT_PATCH = '513590' CROSTC_ROOT = '/usr/local/google/crostc' NIGHTLY_TESTS_DIR = os.path.join(CROSTC_ROOT, 'nightly-tests') @@ -73,6 +70,9 @@ RECIPE_IMAGE_RE = RECIPE_IMAGE_FS.format(**RECIPE_IMAGE_RE_GROUPS) TELEMETRY_AQUARIUM_UNSUPPORTED = ['bob', 'elm', 'veyron_tiger'] +# CL that uses LLVM-Next to build the images (includes chrome). +USE_LLVM_NEXT_PATCH = '513590' + class ToolchainComparator(object): """Class for doing the nightly tests work.""" @@ -226,13 +226,10 @@ class ToolchainComparator(object): crosperf = os.path.join(TOOLCHAIN_DIR, 'crosperf', 'crosperf') noschedv2_opts = '--noschedv2' if self._noschedv2 else '' - command = ('{crosperf} --no_email={no_email} --results_dir={r_dir} ' - '--logging_level=verbose --json_report=True {noschedv2_opts} ' - '{exp_file}').format(crosperf=crosperf, - no_email=not self._test, - r_dir=self._reports_dir, - noschedv2_opts=noschedv2_opts, - exp_file=experiment_file) + no_email = not self._test + command = (f'{crosperf} --no_email={no_email} ' + f'--results_dir={self._reports_dir} --logging_level=verbose ' + f'--json_report=True {noschedv2_opts} {experiment_file}') return self._ce.RunCommand(command) |