diff options
| author | Ryan Beltran <ryanbeltran@chromium.org> | 2022-05-09 21:23:55 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-05-10 17:17:12 +0000 |
| commit | 8ba3a041ada2078f7966d6cf3fb3e0904b1d606d (patch) | |
| tree | 5ba61ab1513b00e7844ee5ccb00c76aa2050ebbb | |
| parent | 3f02e131985582cfe1069452132cd711f9ac1637 (diff) | |
| download | toolchain-utils-8ba3a041ada2078f7966d6cf3fb3e0904b1d606d.tar.gz | |
compiler_wrapper: remove -checks=* for tidy
This CL removes -checks=*` from the Clang Tidy flags when
WITH_TIDY=tricium which allows projects to provide their own
configuration files for clang tidy.
BUG=b:187790543
TEST=manually tested
Change-Id: Ic6893a09146f071874f21f7bedb04a1f85e83284
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3635256
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
| -rw-r--r-- | compiler_wrapper/clang_tidy_flag.go | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/compiler_wrapper/clang_tidy_flag.go b/compiler_wrapper/clang_tidy_flag.go index 8c3712d6..2d2565e0 100644 --- a/compiler_wrapper/clang_tidy_flag.go +++ b/compiler_wrapper/clang_tidy_flag.go @@ -114,9 +114,7 @@ func runClangTidyForTricium(env env, clangCmd *command, cSrcFile, fixesDir strin fixesFilePath := f.Name() + ".yaml" fixesMetadataPath := f.Name() + ".json" - // FIXME(gbiv): Remove `-checks=*` when testing is complete; we should defer to .clang-tidy - // files, which are both more expressive and more approachable than `-checks=*`. - extraTidyFlags = append(extraTidyFlags, "-checks=*", "--export-fixes="+fixesFilePath) + extraTidyFlags = append(extraTidyFlags, "--export-fixes="+fixesFilePath) clangTidyCmd, err := calcClangTidyInvocation(env, clangCmd, cSrcFile, extraTidyFlags...) if err != nil { return fmt.Errorf("calculating tidy invocation: %v", err) |