diff options
| author | Manoj Gupta <manojgupta@google.com> | 2017-03-10 15:56:33 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-03-16 16:27:38 -0700 |
| commit | 92bf473b1812c922babc0fd2fdd2702f267f8315 (patch) | |
| tree | e1f22a516fa37300dc0e95b947514c6877952dc5 | |
| parent | a314af4dbfb1cd331ab84ddeb946f8657b56c921 (diff) | |
| download | toolchain-utils-92bf473b1812c922babc0fd2fdd2702f267f8315.tar.gz | |
Use bash as the default shell for command execution in crosperf.
subprocess.Popen defaults to /bin/sh, however, the intended behavior
is running them with bash.
BUG=None
TEST=Synatx error in . remote_access.sh is gone. Crosperf unit tests
passed.
Change-Id: I059ba9736e5ad3023b5c0a2201f6b40d11ddbe6e
Reviewed-on: https://chromium-review.googlesource.com/452862
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
| -rw-r--r-- | cros_utils/command_executer.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/cros_utils/command_executer.py b/cros_utils/command_executer.py index 0b3a39a1..ae1b2962 100644 --- a/cros_utils/command_executer.py +++ b/cros_utils/command_executer.py @@ -103,7 +103,8 @@ class CommandExecuter(object): stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True, - preexec_fn=os.setsid) + preexec_fn=os.setsid, + executable='/bin/bash') full_stdout = '' full_stderr = '' |