diff options
| author | Manoj Gupta <manojgupta@google.com> | 2017-06-06 11:53:22 -0700 |
|---|---|---|
| committer | Manoj Gupta <manojgupta@chromium.org> | 2017-06-06 20:18:17 +0000 |
| commit | 92a823f8fa2e20a695e02f7aaa7687f57ed9f223 (patch) | |
| tree | 59627122398dade93b4cf15c731887383096695e | |
| parent | c53ca3f32cde74a150a4ddaf5c30e3ce2d2ab32a (diff) | |
| download | toolchain-utils-92a823f8fa2e20a695e02f7aaa7687f57ed9f223.tar.gz | |
Crosperf: Mark benchmark run as failed if it contains no results.
Sometimes telemetry tests do not fail but results are empty.
In that case, mark the run as failed explicitly.
BUG=chromium:729634
TEST=Tested manually on failing lummpy nightly tests. The generated report shows
tests as failed as expected.
Change-Id: Ia52af887e81ed630d7578f9abe93f9656c70512b
Reviewed-on: https://chromium-review.googlesource.com/526392
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
| -rw-r--r-- | crosperf/results_organizer.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/crosperf/results_organizer.py b/crosperf/results_organizer.py index b7641854..bda0cc17 100644 --- a/crosperf/results_organizer.py +++ b/crosperf/results_organizer.py @@ -196,6 +196,7 @@ def OrganizeResults(benchmark_runs, labels, benchmarks=None, json_report=False): # (This can happen if, for example, the test has been disabled.) if len(cur_dict) == 1 and cur_dict['retval'] == 0: cur_dict['retval'] = 1 + benchmark_run.result.keyvals['retval'] = 1 # TODO: This output should be sent via logger. print( "WARNING: Test '%s' appears to have succeeded but returned" |