diff options
| author | George Burgess IV <gbiv@google.com> | 2024-03-27 09:36:20 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2024-03-27 18:35:55 +0000 |
| commit | 44fc9bbb4a14aece874c35feaabf8a3475e3e1c0 (patch) | |
| tree | 04ca0a84c9bf0418eb39c6758e2b1f694d726396 | |
| parent | ad01c999a362ee57476e1f69097b0d0080a062d4 (diff) | |
| download | toolchain-utils-44fc9bbb4a14aece874c35feaabf8a3475e3e1c0.tar.gz | |
update_packages_and_run_tests: set wip on uploaded changes
BUG=b:331607705
TEST=repo upload
Change-Id: If7bbd445f89663a71d922021745a94f856b18758
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5402395
Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
| -rwxr-xr-x | llvm_tools/update_chromeos_llvm_hash.py | 7 | ||||
| -rwxr-xr-x | llvm_tools/update_packages_and_run_tests.py | 3 |
2 files changed, 9 insertions, 1 deletions
diff --git a/llvm_tools/update_chromeos_llvm_hash.py b/llvm_tools/update_chromeos_llvm_hash.py index 7e6b89c2..002fe5fd 100755 --- a/llvm_tools/update_chromeos_llvm_hash.py +++ b/llvm_tools/update_chromeos_llvm_hash.py @@ -571,6 +571,7 @@ def UpdatePackages( extra_commit_msg_lines: Optional[Iterable[str]], delete_branch: bool = True, upload_changes: bool = True, + wip: bool = False, ) -> Optional[git.CommitContents]: """Updates an LLVM hash and uprevs the ebuild of the packages. @@ -594,6 +595,8 @@ def UpdatePackages( Newlines are added automatically. delete_branch: Delete the git branch as a final step. upload_changes: Upload the commit to gerrit as a CL. + wip: if True, any changes uploaded will be uploaded as + work-in-progress. Returns: If upload_changes is set, a git.CommitContents object. Otherwise None. @@ -648,7 +651,9 @@ def UpdatePackages( git.CommitChanges(chromiumos_overlay_path, commit_lines) if upload_changes: change_list = git.UploadChanges( - chromiumos_overlay_path, branch_name + chromiumos_overlay_path, + branch_name, + wip=wip, ) finally: if delete_branch: diff --git a/llvm_tools/update_packages_and_run_tests.py b/llvm_tools/update_packages_and_run_tests.py index 1a0c3ead..34837630 100755 --- a/llvm_tools/update_packages_and_run_tests.py +++ b/llvm_tools/update_packages_and_run_tests.py @@ -550,6 +550,9 @@ def main(): mode=failure_modes.FailureModes.DISABLE_PATCHES, git_hash_source=svn_option, extra_commit_msg_lines=extra_commit_msg_lines, + # b/331607705: set WIP on these changes, so the code-review-nudger bot + # doesn't ping them. + wip=True, ) AddReviewers( |