diff options
| author | cmtice <cmtice@google.com> | 2014-05-12 13:56:42 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 04:07:47 +0000 |
| commit | 798a8fa986db930786b2a6777db0f3b06db995f6 (patch) | |
| tree | feacec28548e4a53f6961cc443915937105a35cf /auto_delete_nightly_test_data.py | |
| parent | df8053336feea245a6bb43fe16dbc16a7b3d71cd (diff) | |
| download | toolchain-utils-798a8fa986db930786b2a6777db0f3b06db995f6.tar.gz | |
Better handling of "not identical machines" failure.
Nightly tests, especially on the x86-generic boxes, fail frequently
because the DUTs have different board images on them, so Crosperf
decides the machines are not identical and refuses to run the tests.
With this CL, if the machine_manager finds that the machines fail the
"identical" test, it will try to push the same image onto all the machines,
and then check them again to see if they are the same. It only tries this
once; if they fail the check the second time around, it is still a fatal
failure. This should eliminate many of the unnecessary failures in our
nightly tests.
This CL also fixes a small bug in the auto-delete script (this fix has
been running for a while on mobiletc-prebuild, but never got committed).
BUG=None
TEST=Ran several iterations where I forced the first "identical" check to
fail. The changes worked.
Change-Id: Ied2a55e5d3e2789e58a503aef03269888954b579
Reviewed-on: https://chrome-internal-review.googlesource.com/163334
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Diffstat (limited to 'auto_delete_nightly_test_data.py')
| -rwxr-xr-x | auto_delete_nightly_test_data.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/auto_delete_nightly_test_data.py b/auto_delete_nightly_test_data.py index faebb5be..fc0e259b 100755 --- a/auto_delete_nightly_test_data.py +++ b/auto_delete_nightly_test_data.py @@ -91,7 +91,7 @@ def Main(argv): # We go back 1 week, delete from that day till we are # options.days_to_preserve away from today. s = d - 7 - e = d - options.days_to_preserve + e = d - int(options.days_to_preserve) rv = 0 for i in range(s + 1, e): if i <= 0: |