diff options
author | Luis Lozano <llozano@chromium.org> | 2015-12-15 13:49:30 -0800 |
---|---|---|
committer | Luis Lozano <llozano@chromium.org> | 2015-12-16 17:36:06 +0000 |
commit | f2a3ef46f75d2196a93d3ed27f4d1fcf22b54fbe (patch) | |
tree | 185d243c7eed7c7a0db6f0e640746cadc1479ea9 /bestflags/task.py | |
parent | 2a66f70fef907c1cb15229cb58e5129cb620ac98 (diff) | |
download | toolchain-utils-f2a3ef46f75d2196a93d3ed27f4d1fcf22b54fbe.tar.gz |
Run pyformat on all the toolchain-utils files.
This gets rid of a lot of lint issues.
Ran by doing this:
for f in *.py; do echo -n "$f " ; if [ -x $f ]; then pyformat -i
--remove_trailing_comma --yapf --force_quote_type=double $f ; else
pyformat -i --remove_shebang --remove_trailing_comma --yapf
--force_quote_type=double $f ; fi ; done
BUG=chromium:567921
TEST=Ran simple crosperf run.
Change-Id: I59778835fdaa5f706d2e1765924389f9e97433d1
Reviewed-on: https://chrome-internal-review.googlesource.com/242031
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Diffstat (limited to 'bestflags/task.py')
-rw-r--r-- | bestflags/task.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/bestflags/task.py b/bestflags/task.py index ee85b1a4..f055fc75 100644 --- a/bestflags/task.py +++ b/bestflags/task.py @@ -1,7 +1,6 @@ # Copyright (c) 2013 The Chromium OS Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. - """A reproducing entity. Part of the Chrome build flags optimization. @@ -257,7 +256,8 @@ class Task(object): for _ in range(BUILD_TRIES): try: # Execute the command and get the execution status/results. - p = subprocess.Popen(command.split(), stdout=subprocess.PIPE, + p = subprocess.Popen(command.split(), + stdout=subprocess.PIPE, stderr=subprocess.PIPE) (out, err) = p.communicate() @@ -311,7 +311,8 @@ class Task(object): # Try TEST_TRIES number of times before confirming that the build fails. for _ in range(TEST_TRIES): try: - p = subprocess.Popen(command.split(), stdout=subprocess.PIPE, + p = subprocess.Popen(command.split(), + stdout=subprocess.PIPE, stderr=subprocess.PIPE) (out, err) = p.communicate() |