diff options
| author | Zhizhou Yang <zhizhouy@google.com> | 2020-02-06 13:37:24 -0800 |
|---|---|---|
| committer | Zhizhou Yang <zhizhouy@google.com> | 2020-02-10 17:47:54 +0000 |
| commit | 05c0470a26e78f56616188841216d76b10094c0d (patch) | |
| tree | e2ef8b39424b7f30d6dd0ff4df7dda5f96456710 /binary_search_tool/MAINTENANCE | |
| parent | 172ccc1af26665a0520db157186e971402a4754c (diff) | |
| download | toolchain-utils-05c0470a26e78f56616188841216d76b10094c0d.tar.gz | |
toolchain-utils: port binary_search_tool to python3
This patch migrates bisect tool in toolchain-utils to python 3.
BUG=chromium:1011676
TEST=Passed all unittests and run_bisect_tests.py
Change-Id: Ia6dd48d927eddcbb2118058f63b33be843d3eb7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2042219
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Auto-Submit: Zhizhou Yang <zhizhouy@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'binary_search_tool/MAINTENANCE')
| -rw-r--r-- | binary_search_tool/MAINTENANCE | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/binary_search_tool/MAINTENANCE b/binary_search_tool/MAINTENANCE index 8e5b3c61..8f96ff10 100644 --- a/binary_search_tool/MAINTENANCE +++ b/binary_search_tool/MAINTENANCE @@ -1,3 +1,7 @@ +# Copyright 2020 The Chromium OS Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + This document is for future maintainers of the binary search/bisection tools. Authors: @@ -21,7 +25,9 @@ The following are good reference materials on how the tool works: TESTING: All unit tests live under the ./test directory. However, these tests -specifically test binary_search_state.py, binary_search_perforce.py, bisect.py. +specifically test binary_search_state.py, binary_search_perforce.py, +run_bisect.py. + These unit tests will not test the specific logic for ChromeOS/Android bisection. To test the ChromeOS/Android bisectors, use the common/hash_test.sh test. This is a simple test case that just checks the hashes of files on your @@ -62,10 +68,11 @@ Some of the design decisions are a bit difficult to understand from just reading the code unfortunately. I will attempt to clear up the major offenders of this: 1. common.py's argument dictionary: - binary_search_state.py and bisect.py both have to have near identical - arguments in order to support argument overriding in bisect.py. However - they do have to be slightly different. Mainly, bisect.py needs to have no - default values for arguments (so it can determine what's being overriden). + binary_search_state.py and run_bisect.py both have to have near identical + arguments in order to support argument overriding in run_bisect.py. However + they do have to be slightly different. Mainly, run_bisect.py needs to have + no default values for arguments (so it can determine what's being + overriden). In order to reduce huge amounts of code duplication for the argument building, we put argument building in common.py. That way both modules |