diff options
| author | Caroline Tice <cmtice@google.com> | 2018-09-19 10:44:27 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-20 15:00:27 -0700 |
| commit | 6b067ab95b15a5aadf5848cd7f2ae9b70c91948b (patch) | |
| tree | 5251259f6c5666e2a5a380f4ca11b115ef41b905 /binary_search_tool/bisect_driver.py | |
| parent | 8c95dfc94ad3b0e93a6d7e9637af2e0dcad3db13 (diff) | |
| download | toolchain-utils-6b067ab95b15a5aadf5848cd7f2ae9b70c91948b.tar.gz | |
Fix bisect_driver.py for Android pylint.
The Android toolchain team has requested that we make this
small pylint change to bisect_driver.py
BUG=886968
TEST=None. This does not affect executable code.
Change-Id: Ia6dc37fc1e204c67b260334b19d1a4ec842924ad
Reviewed-on: https://chromium-review.googlesource.com/1234713
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'binary_search_tool/bisect_driver.py')
| -rw-r--r-- | binary_search_tool/bisect_driver.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/binary_search_tool/bisect_driver.py b/binary_search_tool/bisect_driver.py index 21dd11fa..6a69fbf4 100644 --- a/binary_search_tool/bisect_driver.py +++ b/binary_search_tool/bisect_driver.py @@ -2,6 +2,9 @@ # # This script is used to help the compiler wrapper in the ChromeOS and # Android build systems bisect for bad object files. +# +# pylint: disable=not-callable +# pylint: disable=indentation """Utilities for bisection of ChromeOS and Android object files. This module contains a set of utilities to allow bisection between @@ -139,7 +142,8 @@ def get_obj_path(execargs): # Ignore args that do not create a file. if obj_path in ( '-', - '/dev/null',): + '/dev/null', + ): return '' # Ignore files ending in .tmp. if obj_path.endswith(('.tmp',)): @@ -237,6 +241,7 @@ def cache_file(execargs, bisect_dir, cache, abs_file_path): bisect_dir: The directory where bisection caches live. cache: Which cache the file will be cached to (GOOD/BAD). abs_file_path: Absolute path to file being cached. + Returns: True if caching was successful, False otherwise. """ |