aboutsummaryrefslogtreecommitdiff
path: root/binary_search_tool
diff options
context:
space:
mode:
authorCassidy Burden <cburden@google.com>2016-07-01 15:53:49 -0700
committerchrome-bot <chrome-bot@chromium.org>2016-07-01 17:48:32 -0700
commit39c0c2109ad3b7e89a2a51e0c567b94103415d69 (patch)
tree0e6935012f20714adcd58703209d91d6a0db1643 /binary_search_tool
parentc4671bdd601ff945b2cccbfe1aee9f931dc908c7 (diff)
downloadtoolchain-utils-39c0c2109ad3b7e89a2a51e0c567b94103415d69.tar.gz
binary search tool: Fix typos and small output errors
Change-Id: I0859c43b3bfe8917ebf1e5337f2e39cbb2a55fa0 Reviewed-on: https://chrome-internal-review.googlesource.com/268247 Commit-Ready: Cassidy Burden <cburden@google.com> Tested-by: Cassidy Burden <cburden@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
Diffstat (limited to 'binary_search_tool')
-rw-r--r--binary_search_tool/README.bisect6
-rwxr-xr-xbinary_search_tool/binary_search_state.py6
-rw-r--r--binary_search_tool/common.py3
3 files changed, 9 insertions, 6 deletions
diff --git a/binary_search_tool/README.bisect b/binary_search_tool/README.bisect
index ab83118c..50e4fc18 100644
--- a/binary_search_tool/README.bisect
+++ b/binary_search_tool/README.bisect
@@ -76,14 +76,14 @@ Bisection Methods:
variable and use this to populate emerged objects. Here is an example:
# Defaults to /tmp/sysroot_bisect
- BISECT_DIR="/path/to/where/you/want/to/store/builds/"
+ export BISECT_DIR="/path/to/where/you/want/to/store/builds/"
- BISECT_STAGE="POPULATE_GOOD"
+ export BISECT_STAGE="POPULATE_GOOD"
./switch_to_good_compiler.sh
emerge-${board} -C ${package_to_bisect}
emerge-${board} ${package_to_bisect}
- BISECT_STAGE="POPULATE_BAD"
+ export BISECT_STAGE="POPULATE_BAD"
./switch_to_bad_compiler.sh
emerge-${board} -C {package_to_bisect}
emerge-${board} ${package_to_bisect}
diff --git a/binary_search_tool/binary_search_state.py b/binary_search_tool/binary_search_state.py
index c584b5ef..aa7bb9bd 100755
--- a/binary_search_tool/binary_search_state.py
+++ b/binary_search_tool/binary_search_state.py
@@ -128,8 +128,12 @@ class BinarySearchState(object):
return ret
def DoVerify(self):
+ if not self.verify_level:
+ return
+
self.l.LogOutput('VERIFICATION')
- self.l.LogOutput('Beginning %d tests to verify good/bad sets\n')
+ self.l.LogOutput('Beginning %d tests to verify good/bad sets\n' %
+ self.verify_level)
for _ in range(int(self.verify_level)):
self.l.LogOutput('Resetting all items to good to verify.')
self.SwitchToGood(self.all_items)
diff --git a/binary_search_tool/common.py b/binary_search_tool/common.py
index c1e938fa..dbbb638e 100644
--- a/binary_search_tool/common.py
+++ b/binary_search_tool/common.py
@@ -163,8 +163,7 @@ def _BuildArgsDict(args):
dest='prune',
action='store_true',
default=False,
- help=('Script to run to test the output after '
- 'packages are built.'))
+ help='Continue until all bad items are found.')
# --prune False override, opposite of --prune
args.AddArgument('--noprune',
dest='prune',