diff options
| author | Zhizhou Yang <zhizhouy@google.com> | 2018-10-03 18:12:55 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-10-05 15:43:38 -0700 |
| commit | 3abfae995207551e45c6cf1255d1986071131713 (patch) | |
| tree | 3cdc76fe2a7a9e2c4b3102df07817a09ab404eb9 /binary_search_tool | |
| parent | b54e42c61263fd299a3ca458c13936ad6b987506 (diff) | |
| download | toolchain-utils-3abfae995207551e45c6cf1255d1986071131713.tar.gz | |
Bisect tool: Use symbolic link for replacing object files on Android
The bisection tool used hard link to replace object files from good/bad
set on Android. I do not see why it is necessary to use hard link than
symbolic one, and it will introduce hidden bug if try to link one obj
from one disk to the other.
Test=Tested with Android and succeeded.
Bug=None
Change-Id: If0a1f7f0736052547462fadc955587092dada722
Reviewed-on: https://chromium-review.googlesource.com/1260251
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Diffstat (limited to 'binary_search_tool')
| -rwxr-xr-x | binary_search_tool/android/switch_to_bad.sh | 2 | ||||
| -rwxr-xr-x | binary_search_tool/android/switch_to_good.sh | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/binary_search_tool/android/switch_to_bad.sh b/binary_search_tool/android/switch_to_bad.sh index f746b628..d44f9f13 100755 --- a/binary_search_tool/android/switch_to_bad.sh +++ b/binary_search_tool/android/switch_to_bad.sh @@ -18,7 +18,7 @@ source android/common.sh OBJ_LIST_FILE=$1 # Symlink from BAD obj to working tree. -SWITCH_CMD="ln -f ${BISECT_BAD_BUILD}/{} {}; touch {};" +SWITCH_CMD="ln -sf ${BISECT_BAD_BUILD}/{} {}; touch {};" overall_status=0 diff --git a/binary_search_tool/android/switch_to_good.sh b/binary_search_tool/android/switch_to_good.sh index 1c046c3f..557553c3 100755 --- a/binary_search_tool/android/switch_to_good.sh +++ b/binary_search_tool/android/switch_to_good.sh @@ -17,7 +17,7 @@ source android/common.sh OBJ_LIST_FILE=$1 # Symlink from GOOD obj to working tree. -SWITCH_CMD="ln -f ${BISECT_GOOD_BUILD}/{} {}; touch {};" +SWITCH_CMD="ln -sf ${BISECT_GOOD_BUILD}/{} {}; touch {};" overall_status=0 |