cros_utils/buildbot_utils: leverage `cros buildresult`

Originally it sends a http request to some magic URL and parse the
contents. Now there is a `cros buildresult` available for use.

BUG=chromium:807029
TEST=cros_utils/buildbot_utils_unittest.py
     buildbot_test_toolchains.py

Change-Id: I33441859afd675c1a6b70d3d1f4e2348d54cbd77
Reviewed-on: https://chromium-review.googlesource.com/954052
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

1 files changed, 9 insertions, 25 deletions

diff --git a/buildbot_test_llvm.py b/buildbot_test_llvm.py
index 397602ba..4e7a166e 100755
--- a/buildbot_test_llvm.py
+++ b/buildbot_test_llvm.py
@@ -118,7 +118,7 @@ class ToolchainVerifier(object):
     if ret_val != 0:
       raise RuntimeError('chmod for testing_rsa failed')
 
-  def DoAll(self, crostc_dir):
+  def DoAll(self):
     """Main function inside ToolchainComparator class.
 
     Launch trybot, get image names, create crosperf experiment file, run
@@ -127,23 +127,13 @@ class ToolchainVerifier(object):
     date_str = datetime.date.today()
     description = 'master_%s_%s_%s' % (self._patches_string, self._build,
                                        date_str)
-    if crostc_dir:
-      _ = buildbot_utils.GetTrybotImage(
-          self._chromeos_root,
-          self._build,
-          self._patches,
-          description,
-          tryjob_flags=['--hwtest'],
-          credentials_dir=crostc_dir,
-          async=True)
-    else:
-      _ = buildbot_utils.GetTrybotImage(
-          self._chromeos_root,
-          self._build,
-          self._patches,
-          description,
-          tryjob_flags=['--hwtest'],
-          async=True)
+    _ = buildbot_utils.GetTrybotImage(
+        self._chromeos_root,
+        self._build,
+        self._patches,
+        description,
+        tryjob_flags=['--hwtest'],
+        async=True)
 
     return 0
 
@@ -177,12 +167,6 @@ def Main(argv):
       dest='compiler',
       help='Which compiler (llvm, llvm-next or gcc) to use for '
       'testing.')
-  parser.add_argument(
-      '--crostc_dir',
-      dest='crostc_dir',
-      help='Path to the directory containing the '
-      'chromeos-toolchain-credentials.json file; normally in the '
-      'crostc repo.')
 
   options = parser.parse_args(argv[1:])
   if not options.chromeos_root:
@@ -207,7 +191,7 @@ def Main(argv):
       board = TEST_BOARD[(start_board + i) % len(TEST_BOARD)]
       fv = ToolchainVerifier(board, options.chromeos_root, options.weekday,
                              options.patches, options.compiler)
-      fv.DoAll(options.crostc_dir)
+      fv.DoAll()
     except SystemExit:
       logfile = os.path.join(VALIDATION_RESULT_DIR, options.compiler, board)
       with open(logfile, 'w') as f: