diff options
| author | Caroline Tice <cmtice@google.com> | 2016-10-18 15:27:51 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-10-18 16:47:44 -0700 |
| commit | de600776d8342db1ae2579efd4ca07adbc310d6c (patch) | |
| tree | 99d336379076098fd18a3c32f8136f17e87b75b5 /buildbot_test_llvm.py | |
| parent | bf3d6f017149ee218f731d21b9bf076637733348 (diff) | |
| download | toolchain-utils-de600776d8342db1ae2579efd4ca07adbc310d6c.tar.gz | |
[toolchain-utils] Fix rotating builders to work with no patches.
Currently if no patch is passed to cbuildbot, it hangs; similarly if
no patch is given to the rotating builder script, it dies. This CL
fixes both of those. It also temporarily stops the rotating builders
from sending emails until we can figure out how to fix their reports.
BUG=chromium:657060
TEST=Tested changes in role account;seemed to work.
Change-Id: I4ba70b562f9cb44d396361cd6461230d7080c6e9
Reviewed-on: https://chrome-internal-review.googlesource.com/297584
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Ting-Yuan Huang <laszio@google.com>
Diffstat (limited to 'buildbot_test_llvm.py')
| -rwxr-xr-x | buildbot_test_llvm.py | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/buildbot_test_llvm.py b/buildbot_test_llvm.py index 479a2550..dfb04994 100755 --- a/buildbot_test_llvm.py +++ b/buildbot_test_llvm.py @@ -58,7 +58,7 @@ class ToolchainVerifier(object): self._l = logger.GetLogger() self._compiler = compiler self._build = '%s-%s-toolchain' % (board, compiler) - self._patches = patches.split(',') + self._patches = patches.split(',') if patches else [] self._patches_string = '_'.join(str(p) for p in self._patches) if not weekday: @@ -105,6 +105,11 @@ class ToolchainVerifier(object): def SendEmail(start_board, compiler): """Send out the test results for all the boards.""" + + # This is no longer the correct way to get results. Until + # this is fixed, don't send any email at all. + return 0 + results = '' for i in range(len(TEST_BOARD)): board = TEST_BOARD[(start_board + i) % len(TEST_BOARD)] @@ -150,6 +155,7 @@ def Main(argv): parser.add_argument( '--patch', dest='patches', + default='', help='The patches to use for the testing, ' "seprate the patch numbers with ',' " 'for more than one patches.') @@ -166,9 +172,8 @@ def Main(argv): if not options.compiler: print('Please specify which compiler to test (gcc, llvm, or llvm-next).') return 1 - if options.patches: - patches = options.patches - elif options.compiler == 'llvm': + patches = options.patches + if not patches and options.compiler == 'llvm': patches = USE_LLVM_PATCH if options.board: |