diff options
| author | George Burgess IV <gbiv@google.com> | 2019-07-24 23:20:57 -0700 |
|---|---|---|
| committer | George Burgess <gbiv@chromium.org> | 2019-07-25 16:08:53 +0000 |
| commit | 9a6dae865659ce5e32694ae92bd3f1f7310d0049 (patch) | |
| tree | fb35dd1b9746822d1d98e6777744e288ba20bd8d /buildbot_test_toolchains.py | |
| parent | adcb8bff41c7f3756756cbe581547897ad49d098 (diff) | |
| download | toolchain-utils-9a6dae865659ce5e32694ae92bd3f1f7310d0049.tar.gz | |
toolchain-utils: remove all xranges
This removes all mention of xrange from toolchain-utils (modulo ones
being changed in other CLs that are in flight). It's now an apparent
lint error to use xrange, and it hinders our move to python3.
As commented on If90d26664c70ccb73750f17573b89933fdb048f4, xrange ->
range in python2 is really only a space concern (or speed in
pathological cases), so migrations of this nature are generally super
straightforward. I glanced at each of these callsites, and none of them
appear to be pathological, so my hope is that this should all be Just
Fine :)
(Also fun to note that this includes a .diff file that has python code
embedded in it.)
BUG=None
TEST=Presubmit tests
Change-Id: Ic9f3ac3a5044d7a07da8a249bc505278d98203de
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1717130
Commit-Queue: George Burgess <gbiv@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'buildbot_test_toolchains.py')
| -rwxr-xr-x | buildbot_test_toolchains.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/buildbot_test_toolchains.py b/buildbot_test_toolchains.py index c2d88733..169b5150 100755 --- a/buildbot_test_toolchains.py +++ b/buildbot_test_toolchains.py @@ -129,7 +129,7 @@ class ToolchainComparator(object): assert mo image_dict = mo.groupdict() image_dict['image_type'] = 'chrome-pfq' - for _ in xrange(2): + for _ in range(2): image_dict['tip'] = str(int(image_dict['tip']) - 1) nonafdo_image = PFQ_IMAGE_FS.replace('\\', '').format(**image_dict) if buildbot_utils.DoesImageExist(self._chromeos_root, nonafdo_image): |