diff options
| author | cmtice <cmtice@google.com> | 2015-02-05 11:04:11 -0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-02-05 23:56:05 +0000 |
| commit | d54f980a7349e06059df5c830643e34aac79b86e (patch) | |
| tree | 548e660175ab08232df02de8ae7f6bc81239f283 /buildbot_test_toolchains.py | |
| parent | 2da6494fed2e849e360ea2ae5d9e880afdb1cb68 (diff) | |
| download | toolchain-utils-d54f980a7349e06059df5c830643e34aac79b86e.tar.gz | |
Make fatal errors if trybot job fails or trybot image is empty.
Update GetTrybotImage to check the final trybot job status and
return an error if the job did not have a success status. Also
update the nightly buildbot test jobs to fail fatally if the
trybot or vanilla image names are empty.
BUG=None
TEST=Tested this in role account.
Change-Id: I17c4ca5fa77ea488c8bf3ae4e5c225b747c90c87
Reviewed-on: https://chrome-internal-review.googlesource.com/196095
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Diffstat (limited to 'buildbot_test_toolchains.py')
| -rw-r--r-- | buildbot_test_toolchains.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/buildbot_test_toolchains.py b/buildbot_test_toolchains.py index bc2c0566..c83f9d83 100644 --- a/buildbot_test_toolchains.py +++ b/buildbot_test_toolchains.py @@ -198,6 +198,12 @@ class ToolchainComparator(): print ("trybot_image: %s" % trybot_image) print ("vanilla_image: %s" % vanilla_image) + if len(trybot_image) == 0: + self._l.LogError("Unable to find trybot_image for %s!" % description) + return 1 + if len(vanilla_image) == 0: + self._l.LogError("Unable to find vanilla image for %s!" % description) + return 1 if os.getlogin() == ROLE_ACCOUNT: self._FinishSetup() |