diff options
| author | Tobias Bosch <tbosch@google.com> | 2019-07-10 06:23:57 -0700 |
|---|---|---|
| committer | Tobias Bosch <tbosch@google.com> | 2019-07-11 08:28:16 +0000 |
| commit | 9332d21c19199f99886b1476cab6f4dd89e82a72 (patch) | |
| tree | 2825d3172d14a689305cb00fa9545d30040947e6 /compiler_wrapper/clang_syntax_flag.go | |
| parent | 4044dab9b197cb72281b540750e425180028897f (diff) | |
| download | toolchain-utils-9332d21c19199f99886b1476cab6f4dd89e82a72.tar.gz | |
Unify command error handling
BUG=chromium:773875
TEST=unit test
Change-Id: Ibe32309c021d72e08cecc7d6830756fa1503e809
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1695801
Reviewed-by: Tobias Bosch <tbosch@google.com>
Tested-by: Tobias Bosch <tbosch@google.com>
Diffstat (limited to 'compiler_wrapper/clang_syntax_flag.go')
| -rw-r--r-- | compiler_wrapper/clang_syntax_flag.go | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/compiler_wrapper/clang_syntax_flag.go b/compiler_wrapper/clang_syntax_flag.go index 7a3d0a31..5ea1cca1 100644 --- a/compiler_wrapper/clang_syntax_flag.go +++ b/compiler_wrapper/clang_syntax_flag.go @@ -17,12 +17,6 @@ func checkClangSyntax(env env, clangCmd *command) (exitCode int, err error) { args: append(clangCmd.args, "-fsyntax-only", "-stdlib=libstdc++"), envUpdates: clangCmd.envUpdates, } - if err := env.run(clangSyntaxCmd, env.stdout(), env.stderr()); err != nil { - if exitCode, ok := getExitCode(err); ok { - return exitCode, nil - } - return exitCode, wrapErrorwithSourceLocf(err, "failed to call clang for syntax check. Command: %#v", - clangSyntaxCmd) - } - return exitCode, nil + return wrapSubprocessErrorWithSourceLoc(clangSyntaxCmd, + env.run(clangSyntaxCmd, env.stdout(), env.stderr())) } |