diff options
| author | Bob Haarman <inglorion@google.com> | 2020-07-09 17:14:53 -0700 |
|---|---|---|
| committer | Bob Haarman <inglorion@chromium.org> | 2020-07-14 19:59:18 +0000 |
| commit | 94fd622c652b7aa46f2ca24d3a0efe93c7fde040 (patch) | |
| tree | 8fd77289f99163ebaae2a0e1f7f250fbf0081cdf /compiler_wrapper/config.go | |
| parent | 6cfbb3d75dbd5383419814804f4d94b699537b50 (diff) | |
| download | toolchain-utils-94fd622c652b7aa46f2ca24d3a0efe93c7fde040.tar.gz | |
compiler_wrapper: remove -grecord-gcc-switches
-grecord-gcc-switches causes the compiler and compiler flags to be
stored in the produced debug information. This causes Goma builds to
be non-deterministic, because the compiler path differs depending
on whether the compiler was run locally or on Goma. This, in turn,
causes cache pollution and needless work. Since we are not in
fact using the information stored by -grecord-gcc-switches, this
change disables it. We can re-enable it when we want to start
using the information, provided we come up with another way to
avoid the issues described earlier.
BUG=chromium:1103065
TEST=Build an object file in chromeos-chrome and check that info is absent
Change-Id: Ib8022a3a1baf2e4b5d3d9d1453deb67f539baff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2290624
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tiancong Wang <tcwang@google.com>
Diffstat (limited to 'compiler_wrapper/config.go')
| -rw-r--r-- | compiler_wrapper/config.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/compiler_wrapper/config.go b/compiler_wrapper/config.go index b11c6808..0fc7336f 100644 --- a/compiler_wrapper/config.go +++ b/compiler_wrapper/config.go @@ -121,9 +121,10 @@ var crosHardenedConfig = &config{ // Disable "-faddrsig" since it produces object files that strip doesn't understand, chromium:915742. // Pass "-fcommon" till the packages are fixed to work with new clang default // "-fno-common", crbug.com/1060413. + // crbug.com/1103065: -grecord-gcc-switches pollutes the Goma cache; + // removed that flag for now. clangFlags: []string{ "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -188,9 +189,10 @@ var crosHostConfig = &config{ // Temporarily add no-unknown-warning-option to deal with old clang versions. // Pass "-fcommon" till the packages are fixed to work with new clang default // "-fno-common", crbug.com/1060413. + // crbug.com/1103065: -grecord-gcc-switches pollutes the Goma cache; + // removed that flag for now. clangFlags: []string{ "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-fuse-ld=lld", |